From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: multiple hit on TLB
Date: Sat, 09 Feb 2008 04:26:53 +0000 [thread overview]
Message-ID: <20080209042653.GA24622@linux-sh.org> (raw)
In-Reply-To: <20080208.141034.46637747.saito@densan.co.jp>
On Fri, Feb 08, 2008 at 02:10:34PM +0900, Hideo Saito wrote:
> On linux-2.6.24 for SH7780, I see a multiple hit in UTLB entries, for
> example, if |p->x| causes TLB miss exception in the following code.
>
> a = p->x; |do_page_fault| is called and UTLB is updated to read from |p->x|
> p->x = b; |__do_page_fault| is called and UTLB is updated to write to |p->x|
>
> I think following code should not be removed for TLB miss optimizations.
>
Well, I'm glad someone hit this at least. Yes, if you are having multiple
hits then this needs to be left in place. Initially we removed it for the
SMP case, so it looks like it will have to be conditionalized at this
point. I'll look in to it a bit more and queue up a pach for -rc1 and
-stable, thanks.
prev parent reply other threads:[~2008-02-09 4:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-08 5:10 multiple hit on TLB Hideo Saito
2008-02-09 4:26 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080209042653.GA24622@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox