[PATCH] SH/Dreamcast - improve detection of attached peripherals

[PATCH] SH/Dreamcast - improve detection of attached peripherals

[Adrian McMenamin]

Improve device detection for maple through longer delay

Experience suggests that a much longer delay in setting up the Maple bus
on the Dreamcast leads to better hardware detection.

Signed-off-by: Adrian McMenamin <adrian@mcmen.demon.co.uk>

-----

diff --git a/drivers/sh/maple/maple.c b/drivers/sh/maple/maple.c
index fbca7f8..afb5362 100644
--- a/drivers/sh/maple/maple.c
+++ b/drivers/sh/maple/maple.c
@@ -658,7 +658,6 @@ static int __init maple_bus_init(void)
 		goto cleanup_device;
 
 	retval = driver_register(&maple_dummy_driver.drv);
-
 	if (retval)
 		goto cleanup_bus;
 
@@ -704,7 +703,7 @@ static int __init maple_bus_init(void)
 		mdev[i]->mq->length = 0;
 		maple_add_packet(mdev[i]->mq);
 		/* delay aids hardware detection */
-		udelay(20);
+		mdelay(5);
 		subdevice_map[i] = 0;
 	}
 

Re: [PATCH] SH/Dreamcast - improve detection of attached peripherals

[Paul Mundt]

On Mon, Feb 11, 2008 at 12:25:02AM +0000, Adrian McMenamin wrote:
> Improve device detection for maple through longer delay
> 
> Experience suggests that a much longer delay in setting up the Maple bus
> on the Dreamcast leads to better hardware detection.
> 
> Signed-off-by: Adrian McMenamin <adrian@mcmen.demon.co.uk>
> 
> -----
> 
3 -'s only. Not 5, 3.

Patch subjects should follow the format of 'subsystem: description'. In
this case, 'maple: improve detection of attached peripherals'.

On Mon, Feb 11, 2008 at 06:41:49PM +0100, Kristoffer Ericson wrote:
> Greetings,
> 
> shortlog:
> This patch removes defunct. led support functions from hp6xx.h since they are now 
> added in a proper driver (see commit below). Also adds tabs instead of spaces before comments.
> 
> *commit d39a7a63eb3971b1b3cc5c181ed526bf437b1c72
> 
This goes directly in to the commit log. You do not need a greeting, and
you do not need a shortlog:. Provide a meaningful subject, and then a
short and concise description in the body, nothing more, and nothing
less. Also, please ensure that you do not go beyond 80 cols in the text
of your body. This not only applies to patch descriptions, but also to
any mail you send to the list.

Also, no attachments or MIME damage of any sort. If you aren't sure
whether your mailer will mangle the inline patch or not, send it to
yourself until you have it working.

> signed-off-by: Kristoffer Ericson <kristoffer.ericson@gmail.com>
> 
Signed-off-by. With an upper-case S.

I suggest you both re-read Documentation/SubmittingPatches and look out
for deviations. This stuff is documented incredibly clearly, and yet
there is constant trouble with this for whatever reason. Beyond that,
please try applying your patches to a test tree with git-am _before_
sending it to the list. You will very quickly see what needs to be
corrected.

I don't mind fixing these things up and merging the patches by hand from
time to time, but when every single patch submission requires manual
mangling, it simply gets to be a headache.

Please try to follow the established conventions in the future. It will
save everyone a lot of time.

Re: [PATCH] SH/Dreamcast - improve detection of attached

[Kristoffer Ericson]

On Tue, 12 Feb 2008 17:24:25 +0900
Paul Mundt <lethal@linux-sh.org> wrote:

> On Mon, Feb 11, 2008 at 12:25:02AM +0000, Adrian McMenamin wrote:
> > Improve device detection for maple through longer delay
> > 
> > Experience suggests that a much longer delay in setting up the Maple bus
> > on the Dreamcast leads to better hardware detection.
> > 
> > Signed-off-by: Adrian McMenamin <adrian@mcmen.demon.co.uk>
> > 
> > -----
> > 
> 3 -'s only. Not 5, 3.
> 
> Patch subjects should follow the format of 'subsystem: description'. In
> this case, 'maple: improve detection of attached peripherals'.
> 
> On Mon, Feb 11, 2008 at 06:41:49PM +0100, Kristoffer Ericson wrote:
> > Greetings,
> > 
> > shortlog:
> > This patch removes defunct. led support functions from hp6xx.h since they are now 
> > added in a proper driver (see commit below). Also adds tabs instead of spaces before comments.
> > 
> > *commit d39a7a63eb3971b1b3cc5c181ed526bf437b1c72
> > 
> This goes directly in to the commit log. You do not need a greeting, and
> you do not need a shortlog:. Provide a meaningful subject, and then a
> short and concise description in the body, nothing more, and nothing
> less. Also, please ensure that you do not go beyond 80 cols in the text
> of your body. This not only applies to patch descriptions, but also to
> any mail you send to the list.
> 

Ah, that I didn't know. Thought everything after the shortlog was 
automaticly cut&pasted. Thx.

> Also, no attachments or MIME damage of any sort. If you aren't sure
> whether your mailer will mangle the inline patch or not, send it to
> yourself until you have it working.

I wasn't aware my attachments was being mangled in anyway, I'll test on 
myself until I got it sorted.

> 
> > signed-off-by: Kristoffer Ericson <kristoffer.ericson@gmail.com>
> > 
> Signed-off-by. With an upper-case S.

Roger.

> 
> I suggest you both re-read Documentation/SubmittingPatches and look out
> for deviations. This stuff is documented incredibly clearly, and yet
> there is constant trouble with this for whatever reason. Beyond that,
> please try applying your patches to a test tree with git-am _before_
> sending it to the list. You will very quickly see what needs to be
> corrected.
> 
> I don't mind fixing these things up and merging the patches by hand from
> time to time, but when every single patch submission requires manual
> mangling, it simply gets to be a headache.
> 
> Please try to follow the established conventions in the future. It will
> save everyone a lot of time.

Thx for info paul. I'll do that.

Re: [PATCH] SH/Dreamcast - improve detection of attached peripherals

[Paul Mundt]

On Tue, Feb 12, 2008 at 10:36:12AM +0100, Kristoffer Ericson wrote:
> On Tue, 12 Feb 2008 17:24:25 +0900
> Paul Mundt <lethal@linux-sh.org> wrote:
> > Also, no attachments or MIME damage of any sort. If you aren't sure
> > whether your mailer will mangle the inline patch or not, send it to
> > yourself until you have it working.
> 
> I wasn't aware my attachments was being mangled in anyway, I'll test on 
> myself until I got it sorted.
> 
My point is that you should not be attaching patches in the first place.
The only reason people have for sending patches as attachments is because
the inline patch gets mangled. There is never a valid reason for sending
a patch as an attachment to the mailing list, it's just a lot more
tedious to deal with. Unfortunately there are valid reasons for sending
an attachment to the list, so we can't just have messages with
attachments auto-discarded, which would be preferable otherwise.

text/plain attachments can occasionally be tolerated, but most mailers
tend to use some ridiculous mime type for patches, which means one has to
mangle the type back to something sensible before it can be worked with
anyways, which is also quite irritating.

Logs and .configs and things of that nature can be attached just fine,
since they're not fed through scripts as the patches are, and rarely need
to be replied to in-line.

Re: [PATCH] SH/Dreamcast - improve detection of attached peripherals

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]

is there a reason you guys dont use git to submit your patches ?  it does take 
time to learn if you arent familiar, but the time spent more than pays off in 
the long wrong ... it takes care of all these fun bits for you.  a shortened 
list for arbitrary developers:
1. < make changes to git repo >
2. git add < files you want to commit >
3. git commit -s
 - first line is the subject (so you have to follow convention yourself)
 - one blank line
 - paragraph for body of changelog
so the example commit log would be (just the stuff between the dashes):
----------------------------
SH/Maple/Dreamcast: improve detection of attached peripherals

Blah blah blah this is the long subject explaining why this is wanted.

Signed-off-line: automatically-added-by-the-s-flag
----------------------------
4. git-format-patch HEAD^
5. git-send-email --to linux-sh@vger.kernel.org <list of patches produced>
6. git reset --hard HEAD^

i'm lazy and dont create branches for the small one-off changes.  so you guys 
doing more work would probably want to create a branch before doing the work.  
in that case, just replace "HEAD^" with like "master" to generate patches of 
all the commits made to your branch.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]

Re: [PATCH] SH/Dreamcast - improve detection of attached

[Adrian McMenamin]

On Tue, February 12, 2008 8:24 am, Paul Mundt wrote:
>>
> Signed-off-by. With an upper-case S.
>

Are you sure?

I only ask because I came across the sort included in here:

http://lkml.org/lkml/2006/9/22/319

Re: [PATCH] SH/Dreamcast - improve detection of attached

[Adrian McMenamin]

On Wed, February 13, 2008 1:24 pm, Adrian McMenamin wrote:
> On Tue, February 12, 2008 8:24 am, Paul Mundt wrote:
>>>
>> Signed-off-by. With an upper-case S.
>>
>
> Are you sure?
>
> I only ask because I came across the sort included in here:
>
> http://lkml.org/lkml/2006/9/22/319
>
Doh. yes I have now man'ed grep so know how stupid I now look.

Re: [PATCH] SH/Dreamcast - improve detection of attached

[Kristoffer Ericson]

On Tue, 12 Feb 2008 10:23:40 -0500
Mike Frysinger <vapier@gentoo.org> wrote:

> is there a reason you guys dont use git to submit your patches ?  it does take 
> time to learn if you arent familiar, but the time spent more than pays off in 
> the long wrong ... it takes care of all these fun bits for you.  a shortened 
> list for arbitrary developers:

I use git daily to maintain the jlime kernel source repository, don't use it to create patches though.

> 1. < make changes to git repo >
> 2. git add < files you want to commit >
> 3. git commit -s
>  - first line is the subject (so you have to follow convention yourself)
>  - one blank line
>  - paragraph for body of changelog
> so the example commit log would be (just the stuff between the dashes):
> ----------------------------
> SH/Maple/Dreamcast: improve detection of attached peripherals
> 
> Blah blah blah this is the long subject explaining why this is wanted.
> 
> Signed-off-line: automatically-added-by-the-s-flag
> ----------------------------
> 4. git-format-patch HEAD^

This assumes that your patch is the only diff against current HEAD right? I have loads of changes, so need
to pick out the certain commit. I usually do "git diff origin > mypatch.patch" The format patch adds other stuff?

> 5. git-send-email --to linux-sh@vger.kernel.org <list of patches produced>

That I should use more often.

> 6. git reset --hard HEAD^
> 
> i'm lazy and dont create branches for the small one-off changes.  so you guys 
> doing more work would probably want to create a branch before doing the work.  
> in that case, just replace "HEAD^" with like "master" to generate patches of 
> all the commits made to your branch.
> -mike
> 

My repositories are based on linus tree, but I should create a branch towards linux-sh (got seperate tree for that).

Big thanks for tips, I guess its worth learning all aspects of git.

Re: [PATCH] SH/Dreamcast - improve detection of attached peripherals

[Paul Mundt]

On Thu, Feb 14, 2008 at 10:34:20AM +0100, Kristoffer Ericson wrote:
> On Tue, 12 Feb 2008 10:23:40 -0500
> Mike Frysinger <vapier@gentoo.org> wrote:
> > 1. < make changes to git repo >
> > 2. git add < files you want to commit >
> > 3. git commit -s
> >  - first line is the subject (so you have to follow convention yourself)
> >  - one blank line
> >  - paragraph for body of changelog
> > so the example commit log would be (just the stuff between the dashes):
> > ----------------------------
> > SH/Maple/Dreamcast: improve detection of attached peripherals
> > 
> > Blah blah blah this is the long subject explaining why this is wanted.
> > 
> > Signed-off-line: automatically-added-by-the-s-flag
> > ----------------------------
> > 4. git-format-patch HEAD^
> 
> This assumes that your patch is the only diff against current HEAD right? I have loads of changes, so need
> to pick out the certain commit. I usually do "git diff origin > mypatch.patch" The format patch adds other stuff?
> 
git-format-patch will generate a diff for the range you specify. You can
either use a commit-id as a reference, or track the SH tree in a separate
branch and use the symbolic branch name as a reference. HEAD^ will just
pop one off of HEAD.

> > 5. git-send-email --to linux-sh@vger.kernel.org <list of patches produced>
> 
> That I should use more often.
> 
As git-send-email takes a list of patches, you don't need to bother with
cherry picking or anything like that, you can explicitly just select the
ones to send.

git is there to make your life easier, not harder. It helps to use it for
what you can. Note however that I do rebase my tree frequently, so I
don't particularly encourage people to branch off of it. During non
merge-window times, there's basically no reason to reference my tree.