From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: Add support for Solution Engine SH7721 board
Date: Thu, 20 Mar 2008 04:23:58 +0000 [thread overview]
Message-ID: <20080320042358.GA25681@linux-sh.org> (raw)
In-Reply-To: <47E12059.4020302@renesas.com>
On Wed, Mar 19, 2008 at 11:16:57PM +0900, Yoshihiro Shimoda wrote:
> diff -uprN a/arch/sh/boards/se/7721/io.c b/arch/sh/boards/se/7721/io.c
> --- a/arch/sh/boards/se/7721/io.c 1970-01-01 09:00:00.000000000 +0900
> +++ b/arch/sh/boards/se/7721/io.c 2008-03-19 23:12:00.000000000 +0900
> @@ -0,0 +1,223 @@
> +/*
> + * I/O routine for SH7721 SolutionEngine.
> + *
> + */
> +
> +#include <linux/kernel.h>
> +#include <linux/types.h>
> +#include <asm/se.h>
> +#include <asm/io.h>
> +
> +#define badio(fn, a) panic("bad i/o operation %s for %08lx.", #fn, a)
> +
This io.c is useless, kill it off and use the proper addresses when
registering the platform device.
> diff -uprN a/arch/sh/boards/se/7721/Makefile b/arch/sh/boards/se/7721/Makefile
> --- a/arch/sh/boards/se/7721/Makefile 1970-01-01 09:00:00.000000000 +0900
> +++ b/arch/sh/boards/se/7721/Makefile 2008-03-19 23:12:00.000000000 +0900
> @@ -0,0 +1,10 @@
> +#
> +# Makefile for the HITACHI UL SolutionEngine 7721 specific parts of the kernel
> +#
> +# This file is subject to the terms and conditions of the GNU General Public
> +# License. See the file "COPYING" in the main directory of this archive
> +# for more details.
> +#
> +#
> +
> +obj-y := setup.o irq.o io.o
Please get rid of the Makefile comments.
next prev parent reply other threads:[~2008-03-20 4:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-19 14:16 [PATCH] sh: Add support for Solution Engine SH7721 board Yoshihiro Shimoda
2008-03-20 4:23 ` Paul Mundt [this message]
2008-03-20 13:58 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080320042358.GA25681@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox