From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mundt Date: Fri, 25 Apr 2008 01:30:11 +0000 Subject: Re: [PATCH] i2c: Renesas Highlander FPGA SMBus support. Message-Id: <20080425013011.GA27359@linux-sh.org> List-Id: References: <20080325063236.GA29012@linux-sh.org> <20080423134156.1b368163@hyperion.delvare> <20080423181101.GA2931@roarinelk.homelinux.net> <20080423203104.0ca0f301@hyperion.delvare> In-Reply-To: <20080423203104.0ca0f301@hyperion.delvare> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jean Delvare Cc: Manuel Lauss , i2c@lm-sensors.org, Andrew Morton , linux-sh@vger.kernel.org, Magnus Damm On Wed, Apr 23, 2008 at 08:31:04PM +0200, Jean Delvare wrote: > On Wed, 23 Apr 2008 20:11:01 +0200, Manuel Lauss wrote: > > On Wed, Apr 23, 2008 at 01:41:56PM +0200, Jean Delvare wrote: > > > On Tue, 25 Mar 2008 15:32:36 +0900, Paul Mundt wrote: > > > > This adds support for the SMBus adapter found in the various FPGAs on > > > > the Renesas Highlander platforms. Particularly the R0P7780LC0011RL and > > > > R0P7785LC0011RL FPGAs. > > > > > > > > Functionality is fairly restricted, in that only byte and block data > > > > transfers are supported. Normal/fast mode and IRQ/polling are also > > > > supported. Primarily used for various RTCs and thermal sensors. > > > > > > > > Signed-off-by: Paul Mundt > > > > > > No volunteer to review this driver? Manuel or Magnus maybe? > > > > I don't think I'm qualified to review other peoples' code (it looks > > fine to me). The other thing is Renesas demoboards are impossible to > > get outside of Japan so I think Paul is the only user of this hardware > > who is also interested in linux support. And I'm convinced he knows > > what he's doing ;-) > > I guess that there are more users than just Paul, otherwise he wouldn't > bother pushing his driver upstream, would he? > Even if I were the only user, I would still push it upstream. Though in this case, there are plenty of other users. This is a fairly common reference board in Japan, which we've supported in the kernel in various forms for a few years already. The FPGA SMBus implementation is one of the outstanding bits of support for the platform.