From: "Hans J. Koch" <hjk@linutronix.de>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
lethal@linux-sh.org, hjk@linutronix.de, gregkh@suse.de,
"Uwe Kleine-König" <Uwe.Kleine-Koenig@digi.com>
Subject: Re: [PATCH 01/03] uio: Add enable_irq() callback
Date: Thu, 22 May 2008 20:18:29 +0000 [thread overview]
Message-ID: <20080522201829.GE3226@local> (raw)
In-Reply-To: <aec7e5c30805210458m3d15b89am563e4a94b8eb6f2c@mail.gmail.com>
On Wed, May 21, 2008 at 08:58:24PM +0900, Magnus Damm wrote:
> On Tue, May 20, 2008 at 7:51 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
> > Add enable_irq() callback to struct uio_info. This callback is needed by
> > the uio_platform driver so interrupts can be enabled before blocking.
>
> We can most likely use a single uio platform driver if this patch is
> acceptable. Any NAKs?
Yes. Your approach only allows enabling interrupts, but not disabling
them. And I don't like that it is not possible for generic userspace
tools to find out if a UIO device has this auto-irq-enabling capability
or not.
I just posted a patch that allows enabling _and_ disabling of irqs from
userspace by writing 0 or 1 to /dev/uioX. I've CCed you, could you
please test? If this doesn't do what you need, please let me know.
Thanks,
Hans
next prev parent reply other threads:[~2008-05-22 20:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 10:51 [PATCH 00/03][RFC] Reusable UIO Platform Driver Magnus Damm
2008-05-20 10:51 ` [PATCH 01/03] uio: Add enable_irq() callback Magnus Damm
2008-05-21 11:58 ` Magnus Damm
2008-05-22 20:18 ` Hans J. Koch [this message]
2008-05-23 1:24 ` Magnus Damm
2008-05-23 8:43 ` Hans J. Koch
2008-05-20 10:51 ` [PATCH 02/03] uio: Add uio_platform driver Magnus Damm
2008-05-20 10:51 ` [PATCH 03/03] sh: Export sh7343/sh7722/sh7723 VPU/VEU blocks Magnus Damm
2008-05-20 21:07 ` [PATCH 00/03][RFC] Reusable UIO Platform Driver Hans J. Koch
2008-05-21 3:31 ` Magnus Damm
2008-05-21 6:49 ` Uwe Kleine-König
2008-05-21 7:49 ` Paul Mundt
2008-05-21 8:05 ` Uwe Kleine-König
2008-05-21 8:22 ` Magnus Damm
2008-05-21 8:50 ` Uwe Kleine-König
2008-05-21 8:09 ` Magnus Damm
2008-05-21 9:25 ` Uwe Kleine-König
2008-05-21 10:50 ` Magnus Damm
2008-05-21 11:04 ` Uwe Kleine-König
2008-05-21 11:56 ` Magnus Damm
2008-05-21 12:09 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080522201829.GE3226@local \
--to=hjk@linutronix.de \
--cc=Uwe.Kleine-Koenig@digi.com \
--cc=gregkh@suse.de \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).