From: Sam Ravnborg <sam@ravnborg.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Adrian Bunk <bunk@kernel.org>,
Peter Korsgaard <jacmet@sunsite.dk>,
linux-kernel@vger.kernel.org, dhowells@redhat.com,
andi@firstfloor.org, "Kirill A. Shutemov" <k.shutemov@gmail.com>,
ysato@users.sourceforge.jp, takata@linux-m32r.org,
linux-m32r@ml.linux-m32r.org, kyle@mcmartin.ca, matthew@wil.cx,
grundler@parisc-linux.org, linux-parisc@vger.kernel.org,
lethal@linux-sh.org, linux-sh@vger.kernel.org,
linux-arch@vger.kernel.org
Subject: Re: architectures with ARCH_SUPPORTS_AOUT but no binfmt_aout
Date: Tue, 17 Jun 2008 12:23:46 +0000 [thread overview]
Message-ID: <20080617122346.GA10598@uranus.ravnborg.org> (raw)
In-Reply-To: <1213702113.26255.996.camel@pmac.infradead.org>
On Tue, Jun 17, 2008 at 12:28:33PM +0100, David Woodhouse wrote:
> On Tue, 2008-06-17 at 13:11 +0300, Adrian Bunk wrote:
> > The pattern for this stuff is to provide a HAVE_AOUT kconfig variable
> > that gets select'ed by these architectures.
>
> http://git.infradead.org/users/dwmw2/aout-2.6.git?a=commitdiff;h¥db5179
>
> Subject: [PATCH] Introduce HAVE_AOUT symbol to remove hard-coded arch list for BINFMT_AOUT
>
> HAVE_AOUT doesn't quite do the same thing as the recently removed
> ARCH_SUPPORTS_AOUT config option. That was set even on platforms where
> binfmt_aout isn't supported, although it's not entirely clear why.
>
> So it's best just to introduce a new symbol, handled consistently with
> other similar HAVE_xxx symbols; with a simple 'select' the arch Kconfig.
Looks good.
One minor issue...
> @@ -7,6 +7,7 @@ config ALPHA
> default y
> select HAVE_IDE
> select HAVE_OPROFILE
> + select HAVE_AOUT
Sorting these alphabetically will result in less merge conflicts when the list grows.
Sam
next prev parent reply other threads:[~2008-06-17 12:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1213565555.26255.522.camel@pmac.infradead.org>
[not found] ` <1213604973-7073-1-git-send-email-jacmet@sunsite.dk>
[not found] ` <1213617663.26255.708.camel@pmac.infradead.org>
[not found] ` <20080616121727.GB10854@cs181133002.pp.htv.fi>
[not found] ` <1213619214.26255.721.camel@pmac.infradead.org>
2008-06-17 8:42 ` architectures with ARCH_SUPPORTS_AOUT but no binfmt_aout Adrian Bunk
2008-06-17 9:46 ` David Woodhouse
2008-06-17 10:11 ` Adrian Bunk
2008-06-17 10:18 ` David Woodhouse
2008-06-17 10:24 ` Adrian Bunk
2008-06-17 11:28 ` David Woodhouse
2008-06-17 12:23 ` Sam Ravnborg [this message]
2008-06-17 12:29 ` David Woodhouse
2008-06-17 12:37 ` Sam Ravnborg
2008-06-17 12:54 ` David Woodhouse
2008-06-22 9:49 ` Adrian Bunk
2008-06-22 11:40 ` David Woodhouse
2008-06-22 23:53 ` David McCullough
2008-06-24 11:46 ` Adrian Bunk
2008-06-27 16:27 ` Jeff Dike
2008-06-27 21:12 ` [2.6 patch] remove unused asm/a.out.h files Adrian Bunk
2008-06-17 11:28 ` architectures with ARCH_SUPPORTS_AOUT but no binfmt_aout Matthew Wilcox
2008-06-24 4:15 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080617122346.GA10598@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=andi@firstfloor.org \
--cc=bunk@kernel.org \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=grundler@parisc-linux.org \
--cc=jacmet@sunsite.dk \
--cc=k.shutemov@gmail.com \
--cc=kyle@mcmartin.ca \
--cc=lethal@linux-sh.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m32r@ml.linux-m32r.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=takata@linux-m32r.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox