From: Paul Mundt <lethal@linux-sh.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] sh: export get_cpu_subtype
Date: Tue, 24 Jun 2008 04:03:29 +0000 [thread overview]
Message-ID: <20080624040329.GC22526@linux-sh.org> (raw)
In-Reply-To: <20080618003650.GO25911@cs181133002.pp.htv.fi> <20080617223340.GN25911@cs181133002.pp.htv.fi> <20080617223103.GL25911@cs181133002.pp.htv.fi> <20080617223057.GK25911@cs181133002.pp.htv.fi> <20080617223053.GJ25911@cs181133002.pp.htv.fi> <20080617223040.GI25911@cs181133002.pp.htv.fi> <20080617223023.GH25911@cs181133002.pp.htv.fi>
On Wed, Jun 18, 2008 at 01:30:24AM +0300, Adrian Bunk wrote:
> This patch fixes the following build error:
>
> <-- snip -->
>
> ...
> MODPOST 1837 modules
> ERROR: "get_cpu_subtype" [arch/sh/oprofile/oprofile.ko] undefined!
> ...
> make[2]: *** [__modpost] Error 1
>
> <-- snip -->
>
> Reported-by: Adrian Bunk <bunk@kernel.org>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
On Wed, Jun 18, 2008 at 01:30:40AM +0300, Adrian Bunk wrote:
> This patch fixes the following build error:
>
> <-- snip -->
>
> ...
> MODPOST 1837 modules
> ERROR: "board_pci_channels" [drivers/pcmcia/yenta_socket.ko] undefined!
> ...
> make[2]: *** [__modpost] Error 1
>
> <-- snip -->
>
> I freely admit that it's a pathological configuration, but as long as
> it is allowed it should build.
>
> Reported-by: Adrian Bunk <bunk@kernel.org>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
On Wed, Jun 18, 2008 at 01:30:53AM +0300, Adrian Bunk wrote:
> EXPORT_SYMBOL's in lib-y considered harmful:
>
> <-- snip -->
>
> ...
> MODPOST 1837 modules
> ERROR: "__raw_readsl" [drivers/ssb/ssb.ko] undefined!
> ERROR: "__raw_writesl" [drivers/ssb/ssb.ko] undefined!
> ERROR: "__raw_writesl" [drivers/net/smc91x.ko] undefined!
> ERROR: "__raw_readsl" [drivers/net/smc91x.ko] undefined!
> ERROR: "__raw_writesl" [drivers/net/3c59x.ko] undefined!
> ERROR: "__raw_readsl" [drivers/net/3c59x.ko] undefined!
> ...
> make[2]: *** [__modpost] Error 1
>
> <-- snip -->
>
> Reported-by: Adrian Bunk <bunk@kernel.org>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
On Wed, Jun 18, 2008 at 01:30:57AM +0300, Adrian Bunk wrote:
> This patch makes the needlessly global aica_rtc_{get,set}timeofday()
> static.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
On Wed, Jun 18, 2008 at 01:31:03AM +0300, Adrian Bunk wrote:
> This patch makes the needlessly global EARLY_PCI_OP's static.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
On Wed, Jun 18, 2008 at 01:33:40AM +0300, Adrian Bunk wrote:
> This patch makes the needlessly global pcibios_max_latency static.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
On Wed, Jun 18, 2008 at 03:36:50AM +0300, Adrian Bunk wrote:
> This patch contains the following cleanups:
> - make the following needlessly global code static:
> - cf-enabler.c: cf_init()
> - cpu/clock.c: __clk_enable()
> - cpu/clock.c: __clk_disable()
> - process_32.c: default_idle()
> - time_32.c: struct clocksource_sh
> - timers/timer-tmu.c: struct tmu_timer_ops
> - remove the following unused functions (no CONFIG_BLK_DEV_FD on sh):
> - process_{32,64}.c: disable_hlt()
> - process_{32,64}.c: enable_hlt()
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
These are all applied, thanks.
prev parent reply other threads:[~2008-06-24 4:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-18 0:36 [2.6 patch] sh/kernel/ cleanups Adrian Bunk
2008-06-17 22:33 ` [2.6 patch] sh: make pcibios_max_latency static Adrian Bunk
2008-06-17 22:31 ` [2.6 patch] sh: make EARLY_PCI_OP's static Adrian Bunk
2008-06-17 22:30 ` [2.6 patch] sh/boards/dreamcast/rtc.c: make 2 functions static Adrian Bunk
2008-06-17 22:30 ` [2.6 patch] move arch/sh/lib/io.o to obj-y Adrian Bunk
2008-06-17 22:30 ` [2.6 patch] sh dreamcast: export board_pci_channels Adrian Bunk
2008-06-17 22:30 ` [2.6 patch] sh: export get_cpu_subtype Adrian Bunk
2008-06-18 7:21 ` Change console to another UART oihana
2008-06-18 9:43 ` Nobuhiro Iwamatsu
2008-06-24 4:03 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080624040329.GC22526@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).