From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mundt Date: Tue, 24 Jun 2008 20:01:08 +0000 Subject: Re: [PATCH] maple: tidy maple_driver code by removing redundant Message-Id: <20080624200108.GC11705@renesas.com> List-Id: References: <1213559289.22707.15.camel@localhost.localdomain> <20080624040128.GB22526@linux-sh.org> <5703.85.118.17.158.1214305147.squirrel@newgolddream.dyndns.info> In-Reply-To: <5703.85.118.17.158.1214305147.squirrel@newgolddream.dyndns.info> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Adrian McMenamin Cc: lkml , linux-sh On Tue, Jun 24, 2008 at 11:59:07AM +0100, Adrian McMenamin wrote: > On Tue, June 24, 2008 5:01 am, Paul Mundt wrote: > > On Sun, Jun 15, 2008 at 08:48:09PM +0100, Adrian McMenamin wrote: > >> The connect and disconnect functions are unnecessary - everything they > >> do can be > >> accomplished in the initial probe - so remove them. > >> > >> Signed-off-by: Adrian McMenamin > > > > Applied, thanks. > > > Paul, > > Just to note that this (http://lkml.org/lkml/2008/6/15/122) will break the > keyboard driver unless this (http://lkml.org/lkml/2008/6/15/121) is also > applied. > > I haven't heard back from Dmitry on the keyboard patch yet. > Yes, I'm aware of that. This should fix itself in linux-next once it is merged in the input tree, and I don't intend on pushing my changes until that's in place, so we don't break bisection.