From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
dhowells@redhat.com, gerg@uclinux.org, ralf@linux-mips.org,
linux-mips@linux-mips.org, lethal@linux-sh.org,
linux-sh@vger.kernel.org,
Russell King <rmk+lkml@arm.linux.org.uk>
Subject: Re: [2.6 patch] remove pcibios_update_resource() functions
Date: Fri, 27 Jun 2008 20:14:59 +0000 [thread overview]
Message-ID: <200806271315.01148.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <20080617223332.GM25911@cs181133002.pp.htv.fi>
On Tuesday, June 17, 2008 3:33 pm Adrian Bunk wrote:
> Russell King did the following back in 2003:
>
> <-- snip -->
>
> [PCI] pci-9: Kill per-architecture pcibios_update_resource()
>
> Kill pcibios_update_resource(), replacing it with
> pci_update_resource(). pci_update_resource() uses pcibios_resource_to_bus()
> to convert a resource to a device BAR - the transformation should be
> exactly the same as the transformation used for the PCI bridges.
>
> pci_update_resource "knows" about 64-bit BARs, but doesn't attempt to
> set the high 32-bits to anything non-zero - currently no architecture
> attempts to do something different. If anyone cares, please fix; I'm
> going to reflect current behaviour for the time being.
>
> Ivan pointed out the following architectures need to examine their
> pcibios_update_resource() implementation - they should make sure that
> this new implementation does the right thing. #warning's have been
> added where appropriate.
>
> ia64
> mips
> mips64
>
> This cset also includes a fix for the problem reported by AKPM where
> 64-bit arch compilers complain about the resource mask being placed
> in a u32.
>
> <-- snip -->
>
>
> This patch removes the unused pcibios_update_resource() functions the
> kernel gained since.
>
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Applied to my linux-next tree, thanks Adrian and everyone for your acks.
Jesse
prev parent reply other threads:[~2008-06-27 20:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-17 22:33 [2.6 patch] remove pcibios_update_resource() functions Adrian Bunk
2008-06-18 9:40 ` David Howells
2008-06-19 12:08 ` Greg Ungerer
2008-06-24 3:48 ` Paul Mundt
2008-06-25 23:02 ` Jesse Barnes
2008-06-25 23:41 ` Ralf Baechle
2008-06-27 20:14 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806271315.01148.jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=bunk@kernel.org \
--cc=dhowells@redhat.com \
--cc=gerg@uclinux.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox