From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [RFT PATCH] SuperH HSPI controller driver.
Date: Mon, 21 Jul 2008 12:39:25 +0000 [thread overview]
Message-ID: <20080721123925.GC19854@linux-sh.org> (raw)
In-Reply-To: <20080721090744.GA16714@roarinelk.homelinux.net>
On Mon, Jul 21, 2008 at 11:07:44AM +0200, Manuel Lauss wrote:
> +out2:
> + release_resource(priv->ioarea);
> + kfree(priv->ioarea);
What is this kfree() for?
> +static int __devexit hspi_remove(struct platform_device *pdev)
> +{
> + struct hspi_priv *priv = platform_get_drvdata(pdev);
> +
> + spi_bitbang_stop(&priv->bitbang);
> + iowrite32(0, priv->io + SPCR);
> + iowrite32(0, priv->io + SPSCR);
> + iowrite32(0, priv->io + SPSR);
> + free_irq(priv->irq, priv);
> + iounmap(priv->io);
> + release_resource(priv->ioarea);
> + kfree(priv->ioarea);
Likewise here.
next prev parent reply other threads:[~2008-07-21 12:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 9:07 [RFT PATCH] SuperH HSPI controller driver Manuel Lauss
2008-07-21 12:39 ` Paul Mundt [this message]
2008-07-21 12:46 ` Manuel Lauss
[not found] ` <20080721090744.GA16714-nEyxjcs6f3Vin2gBucwGBecsttgLyre6@public.gmane.org>
2008-08-03 23:52 ` Paul Mundt
2008-08-03 23:57 ` Paul Mundt
2008-08-04 5:49 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080721123925.GC19854@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox