From: Paul Mundt <lethal@linux-sh.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: Yusuke Goda <goda.yusuke@renesas.com>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] SH_AP325RXA must select I2C
Date: Mon, 28 Jul 2008 20:42:36 +0000 [thread overview]
Message-ID: <20080728204236.GB20019@linux-sh.org> (raw)
In-Reply-To: <20080728201705.GC7713@cs181140183.pp.htv.fi>
In-Reply-To: <20080728201705.GC7713@cs181140183.pp.htv.fi>
On Mon, Jul 28, 2008 at 11:17:05PM +0300, Adrian Bunk wrote:
> This patch fixes the following build error:
>
> <-- snip -->
>
> ...
> LD vmlinux
> arch/sh/boards/renesas/ap325rxa/built-in.o: In function `camera_set_capture':
> setup.c:(.text+0x80): undefined reference to `i2c_get_adapter'
> setup.c:(.text+0x88): undefined reference to `i2c_transfer'
> make[1]: *** [vmlinux] Error 1
>
> <-- snip -->
>
> Reported-by: Adrian Bunk <bunk@kernel.org>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
The camera stuff should probably just be conditionalized in the platform
code instead.. Magnus, can you sort out the proper dependencies for this?
next prev parent reply other threads:[~2008-07-28 20:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-28 20:17 [2.6 patch] SH_AP325RXA must select I2C Adrian Bunk
2008-07-28 20:42 ` Paul Mundt [this message]
2008-07-28 22:38 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080728204236.GB20019@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=bunk@kernel.org \
--cc=goda.yusuke@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox