From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] fix build failure when compiling without TRACE_IRQFLAGS_SUPPORT
Date: Fri, 05 Sep 2008 08:44:39 +0000 [thread overview]
Message-ID: <20080905084438.GA4002@linux-sh.org> (raw)
In-Reply-To: <48C0D2A4.90208@st.com>
On Fri, Sep 05, 2008 at 08:33:08AM +0200, Giuseppe CAVALLARO wrote:
> Hi All,
> playing with the kernel configuration we noticed that the
> kernel doesn't build if TRACE_IRQFLAGS_SUPPORT is
> forced off. So this patch just fixes it.
>
> Anyway, we are wondering why it's not possible to disable
> this option from Kconfig.
> Reading the Documentation/irqflags-tracing.txt, this option is
> "needed for CONFIG_PROVE_SPIN_LOCKING and
> CONFIG_PROVE_RW_LOCKING to be offered by the generic
> lock debugging code."
> But we cannot find any references to PROVE_RW_LOCKING etc.
> May be removed?
>
Have you noticed this problem on non-sh platforms also? If so, you should
resend this patch to linux-kernel with the linux-sh list CCed.
The config dependencies are a bit of a mess, but it's all quite
functional. CONFIG_PROVE_RW_LOCKING is bogus though, it's actually
CONFIG_PROVE_LOCKING. Anyways, take a look at lib/Kconfig.debug and it
should all be pretty obvious.
TRACE_IRQFLAGS_SUPPORT is used by quite a lot of things, lockdep, lock
stat, preempt debug, etc. You really do _not_ want to disable this
option, especially as it is a _support_ option, not a functional one.
CONFIG_TRACE_IRQFLAGS itself is what introduces extra overhead, and while
this depends on TRACE_IRQFLAGS_SUPPORT, it also has a dependency on
DEBUG_KERNEL. Thus, you will never see any of this stuff with kernel
debugging disabled. Most of this stuff is hidden away from the user in
Kconfig for a good reason :-)
next prev parent reply other threads:[~2008-09-05 8:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-05 6:33 [PATCH] fix build failure when compiling without TRACE_IRQFLAGS_SUPPORT Giuseppe CAVALLARO
2008-09-05 8:44 ` Paul Mundt [this message]
2008-09-05 11:35 ` Giuseppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080905084438.GA4002@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox