From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Mon, 08 Sep 2008 11:19:27 +0000 Subject: Re: [PATCH] smc91x: SMC_IO_SHIFT platform data support for default Message-Id: <20080908111922.GA15553@verge.net.au> List-Id: References: <20080908050234.11554.10123.sendpatchset@rx1.opensource.se> In-Reply-To: <20080908050234.11554.10123.sendpatchset@rx1.opensource.se> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Magnus Damm Cc: netdev@vger.kernel.org, eric.miao@marvell.com, luca.santini@spesonline.com, nico@cam.org, linux-sh@vger.kernel.org On Mon, Sep 08, 2008 at 02:02:34PM +0900, Magnus Damm wrote: > From: Magnus Damm > > Commit 159198862adad7109bb347bb30a620f67beac45f added SMC_IO_SHIFT > platform data support. After that ARM board support was added. > > The default case is still missing though, so on SuperH SMC_IO_SHIFT > is constantly zero regardless of what you pass as platform data. Hi Magnus, I beleive that its now common practice to include the subject of a commit along with its id, as the latter can change as it moves from tree to tree.