From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kristoffer Ericson Date: Fri, 26 Sep 2008 09:46:57 +0000 Subject: Re: MFD for hd64461 thoughts and ideas Message-Id: <20080926114657.3d4f8969.kristoffer.ericson@gmail.com> List-Id: References: <20080925221814.51b06ed2.kristoffer.ericson@gmail.com> In-Reply-To: <20080925221814.51b06ed2.kristoffer.ericson@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org On Fri, 26 Sep 2008 10:00:02 +0900 Paul Mundt wrote: > On Fri, Sep 26, 2008 at 09:56:39AM +0900, Paul Mundt wrote: > > resource size is off by 1. Should be res->end - res->start - 1. Better > > yet, use the shiny new resource_len() interface that handles this for > > you, so I don't have to make a macro that repeats this sentence every > > time someone posts a driver to the list. ;-) > > > And by - 1 I obviously mean + 1. Yet another reason to use > resource_len(), it fails at typing less than I do. Big thanks for your extensive reponse, I got a clearer picture of whats needed now. Im going to rework the code (alot) and keep everyone updated. The main "problem" is ofcourse the IRQ demuxer but I should have enough references to sort that out. And as you said, its all been done before at some point. Thx -- Kristoffer Ericson