From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: Rework sh7720 GPIO header usage
Date: Mon, 29 Sep 2008 11:20:06 +0000 [thread overview]
Message-ID: <20080929112006.GB20424@linux-sh.org> (raw)
In-Reply-To: <20080929104626.5354.80315.sendpatchset@rx1.opensource.se>
On Mon, Sep 29, 2008 at 08:17:39PM +0900, Paul Mundt wrote:
> On Mon, Sep 29, 2008 at 07:46:26PM +0900, Magnus Damm wrote:
> > From: Magnus Damm <damm@igel.co.jp>
> >
> > This patch reworks the sh7720 gpio includes. Makes space for the
> > generic GPIO code.
> >
> > Signed-off-by: Magnus Damm <damm@igel.co.jp>
> > ---
> >
> > Compile tested with the magicpanelr2_defconfig.
> >
> > arch/sh/include/asm/gpio.h | 8 --------
> > arch/sh/include/asm/magicpanelr2.h | 2 +-
> > drivers/serial/sh-sci.h | 4 +++-
> > 3 files changed, 4 insertions(+), 10 deletions(-)
> >
> Churn in drivers/ for this kind of thing is pretty uninspiring. I'll just
> change the asm/gpio.h ifdef to reference cpu-sh3 explicitly instead. It
> will serve as a reminder that SH-3 still needs to be converted.
Actually, there's not even any point in that. There's no harm in having
the ifdef as it is now remain in the file. Others were there first, so
you'll have to live with it.
next prev parent reply other threads:[~2008-09-29 11:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-29 10:46 [PATCH] sh: Rework sh7720 GPIO header usage Magnus Damm
2008-09-29 11:17 ` Paul Mundt
2008-09-29 11:20 ` Paul Mundt [this message]
2008-09-30 6:27 ` Mark Jonas
2008-09-30 6:40 ` Paul Mundt
2008-09-30 9:31 ` Magnus Damm
2008-09-30 18:25 ` Mark Jonas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080929112006.GB20424@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox