* [PATCH] sh: Add '-up' to ISA flag if enable SH3
@ 2008-10-29 4:31 Nobuhiro Iwamatsu
2008-10-29 4:45 ` Nobuhiro Iwamatsu
2008-10-31 7:09 ` Paul Mundt
0 siblings, 2 replies; 3+ messages in thread
From: Nobuhiro Iwamatsu @ 2008-10-29 4:31 UTC (permalink / raw)
To: linux-sh
By commit of b2d86a3fd9855380598c0c039e712a20086e119f, compilation of SH3 fails.
In current binutils, "pref" opcode is not support SH3. However, it is supported.
Please validate this flag till fix binutils.
Signed-off-by: Nobuhiro Iwamatsu <iwamatsu.nobuhiro@renesas.com>
---
arch/sh/Makefile | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/sh/Makefile b/arch/sh/Makefile
index 3a74ed6..b2d46a6 100644
--- a/arch/sh/Makefile
+++ b/arch/sh/Makefile
@@ -20,6 +20,10 @@ isa-$(CONFIG_CPU_SH4AL_DSP) := sh4al
isa-$(CONFIG_CPU_SH5) := shmedia
isa-$(CONFIG_SH_DSP) := $(isa-y)-dsp
+ifdef CONFIG_CPU_SH3
+isa-y := $(isa-y)-up
+endif
+
cflags-$(CONFIG_CPU_SH2) := $(call cc-option,-m2,)
cflags-$(CONFIG_CPU_SH2A) += $(call cc-option,-m2a,) \
$(call cc-option,-m2a-nofpu,)
--
1.5.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sh: Add '-up' to ISA flag if enable SH3
2008-10-29 4:31 [PATCH] sh: Add '-up' to ISA flag if enable SH3 Nobuhiro Iwamatsu
@ 2008-10-29 4:45 ` Nobuhiro Iwamatsu
2008-10-31 7:09 ` Paul Mundt
1 sibling, 0 replies; 3+ messages in thread
From: Nobuhiro Iwamatsu @ 2008-10-29 4:45 UTC (permalink / raw)
To: linux-sh
Nobuhiro Iwamatsu wrote:
> By commit of b2d86a3fd9855380598c0c039e712a20086e119f, compilation of SH3 fails.
> In current binutils, "pref" opcode is not support SH3. However, it is supported.
> Please validate this flag till fix binutils.
Sorry, this comment is a mistake.
I wanted to write
In current binutils, "pref" and other opcode are processed to SH3 as not supported.
Best regards,
Nobuhiro
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sh: Add '-up' to ISA flag if enable SH3
2008-10-29 4:31 [PATCH] sh: Add '-up' to ISA flag if enable SH3 Nobuhiro Iwamatsu
2008-10-29 4:45 ` Nobuhiro Iwamatsu
@ 2008-10-31 7:09 ` Paul Mundt
1 sibling, 0 replies; 3+ messages in thread
From: Paul Mundt @ 2008-10-31 7:09 UTC (permalink / raw)
To: linux-sh
On Wed, Oct 29, 2008 at 01:45:43PM +0900, Nobuhiro Iwamatsu wrote:
> Nobuhiro Iwamatsu wrote:
> > By commit of b2d86a3fd9855380598c0c039e712a20086e119f, compilation of SH3 fails.
> > In current binutils, "pref" opcode is not support SH3. However, it is supported.
> > Please validate this flag till fix binutils.
>
> Sorry, this comment is a mistake.
> I wanted to write
> In current binutils, "pref" and other opcode are processed to SH3 as not supported.
>
[ random cursing at binutils goes here ]
Yes, you are correct, the -up is necessary. I've re-added it for all
non-SHmedia parts.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-10-31 7:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-29 4:31 [PATCH] sh: Add '-up' to ISA flag if enable SH3 Nobuhiro Iwamatsu
2008-10-29 4:45 ` Nobuhiro Iwamatsu
2008-10-31 7:09 ` Paul Mundt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox