[PATCH] sh: enable and disable clocks recursively

[PATCH] sh: enable and disable clocks recursively

[Magnus Damm]

From: Magnus Damm <damm@igel.co.jp>

Recurse and make sure parent clocks get enabled/disabled.

Signed-off-by: Magnus Damm <damm@igel.co.jp>
---

 arch/sh/kernel/cpu/clock.c |   10 ++++++++++
 1 file changed, 10 insertions(+)

--- 0001/arch/sh/kernel/cpu/clock.c
+++ work/arch/sh/kernel/cpu/clock.c	2008-10-31 17:28:18.000000000 +0900
@@ -117,6 +117,11 @@ int clk_enable(struct clk *clk)
 	unsigned long flags;
 	int ret;
 
+	if (!clk)
+		return -EINVAL;
+
+	clk_enable(clk->parent);
+
 	spin_lock_irqsave(&clock_lock, flags);
 	ret = __clk_enable(clk);
 	spin_unlock_irqrestore(&clock_lock, flags);
@@ -147,9 +152,14 @@ void clk_disable(struct clk *clk)
 {
 	unsigned long flags;
 
+	if (!clk)
+		return -EINVAL;
+
 	spin_lock_irqsave(&clock_lock, flags);
 	__clk_disable(clk);
 	spin_unlock_irqrestore(&clock_lock, flags);
+
+	clk_disable(clk->parent);
 }
 EXPORT_SYMBOL_GPL(clk_disable);
 

Re: [PATCH] sh: enable and disable clocks recursively

[Paul Mundt]

On Fri, Oct 31, 2008 at 08:13:32PM +0900, Magnus Damm wrote:
> Recurse and make sure parent clocks get enabled/disabled.

On Fri, Oct 31, 2008 at 08:14:03PM +0900, Magnus Damm wrote:
> Use divider index value instead of divider value.

On Fri, Oct 31, 2008 at 08:14:28PM +0900, Magnus Damm wrote:
> Use arch_flags to keep track of register and flag number.

On Fri, Oct 31, 2008 at 08:15:07PM +0900, Magnus Damm wrote:
> Add base code to handle new mstpcr clocks. Make sure clock rates propagate.

On Fri, Oct 31, 2008 at 08:15:48PM +0900, Magnus Damm wrote:
> Add sh7722 mstpcr bits and information about their parent clocks.

On Fri, Oct 31, 2008 at 08:16:08PM +0900, Magnus Damm wrote:
> Add sh7723 mstpcr bits and information about their parent clocks.
> The datasheet is pretty clear about the clocks on this device.

On Fri, Oct 31, 2008 at 08:19:38PM +0900, Magnus Damm wrote:
> Add sh7343 mstpcr bits and information about their parent clocks.

On Fri, Oct 31, 2008 at 08:20:23PM +0900, Magnus Damm wrote:
> Add sh7366 mstpcr bits and information about their parent clocks.
> The datasheet is pretty clear about the clocks on this device.

On Fri, Oct 31, 2008 at 08:20:55PM +0900, Magnus Damm wrote:
> Add clock framework support to the sh_mobile i2c driver and
> adjust the processor specific code accordingly.

On Fri, Oct 31, 2008 at 08:21:23PM +0900, Magnus Damm wrote:
> Add clock framework support to the sh_mobile keysc driver and
> adjust the board specific code accordingly.

On Fri, Oct 31, 2008 at 08:21:44PM +0900, Magnus Damm wrote:
> Add clock framework support to the sh_mobile ceu and
> adjust the board specific code accordingly.

On Fri, Oct 31, 2008 at 08:22:13PM +0900, Magnus Damm wrote:
> Add clock framework support to the usbf/m66592 driver and
> adjust the cpu specific code accordingly.

On Fri, Oct 31, 2008 at 08:22:38PM +0900, Magnus Damm wrote:
> Add clock framework support to the usb/r8a66597 driver and
> adjust the cpu specific code accordingly.

On Fri, Oct 31, 2008 at 08:23:26PM +0900, Magnus Damm wrote:
> Add clock framework support to the lcdc driver and
> adjust the board specific code accordingly.

On Fri, Oct 31, 2008 at 08:24:01PM +0900, Magnus Damm wrote:
> Remove the old sh_mobile mstpcr clocks.

All applied, thanks.