[PATCH] usb: r8a66597-hcd: fix wrong data access in SuperH on-chip USB

[PATCH] usb: r8a66597-hcd: fix wrong data access in SuperH on-chip USB

[Yoshihiro Shimoda]

When I used SuperH on-chip USB, there was the problem that accessed
r8a66597_root_hub which was not allocated.

Signed-off-by: Yoshihiro Shimoda <shimoda.yoshihiro@renesas.com>
---
 drivers/usb/host/r8a66597-hcd.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/host/r8a66597-hcd.c b/drivers/usb/host/r8a66597-hcd.c
index c18d879..2376f24 100644
--- a/drivers/usb/host/r8a66597-hcd.c
+++ b/drivers/usb/host/r8a66597-hcd.c
@@ -1763,11 +1763,12 @@ static void r8a66597_timer(unsigned long _r8a66597)
 {
 	struct r8a66597 *r8a66597 = (struct r8a66597 *)_r8a66597;
 	unsigned long flags;
+	int port;

 	spin_lock_irqsave(&r8a66597->lock, flags);

-	r8a66597_root_hub_control(r8a66597, 0);
-	r8a66597_root_hub_control(r8a66597, 1);
+	for (port = 0; port < R8A66597_MAX_ROOT_HUB; port++)
+		r8a66597_root_hub_control(r8a66597, port);

 	spin_unlock_irqrestore(&r8a66597->lock, flags);
 }
-- 
1.5.5

Re: [PATCH] usb: r8a66597-hcd: fix wrong data access in SuperH on-chip USB

[Paul Mundt]

On Tue, Nov 11, 2008 at 04:47:21PM +0900, Yoshihiro Shimoda wrote:
> When I used SuperH on-chip USB, there was the problem that accessed
> r8a66597_root_hub which was not allocated.
> 
> Signed-off-by: Yoshihiro Shimoda <shimoda.yoshihiro@renesas.com>

I've applied this also for 2.6.28, I'll send it out with the rest of the
updates later today, thanks.