From: Kristoffer Ericson <kristoffer.ericson@gmail.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] - Fix dreamcast irq.c formatting
Date: Tue, 18 Nov 2008 15:53:59 +0000 [thread overview]
Message-ID: <20081118175424.19bc9a4b.kristoffer.ericson@gmail.com> (raw)
In-Reply-To: <20081118172847.1ac04194.kristoffer.ericson@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]
On Wed, 19 Nov 2008 00:49:51 +0900
Paul Mundt <lethal@linux-sh.org> wrote:
> On Tue, Nov 18, 2008 at 05:28:47PM +0100, Kristoffer Ericson wrote:
> > This patch cleans the bad formatting
> > found in mach-dreamcast/irq.c file.
> >
> Why even bother? There are more useful things you can be doing with this
> file, like fixing up the comment to deal with the fact there have been
> path changes, converting to the new IRQ model (this is one of the last
> ones left on hw_interrupt_type), etc. Once those sorts of things are out
> of the way, the rest is fairly trivial to tidy, and you can fix up the
> formatting as you go along with regards to new code.
Oki point taken. Ive got no dreamcast to fiddle with
so I'll just leave it alone. Just decided to drop a patch
when I accidently saw the mess it was in.
>
> Whitespace changes have a high risk of causing merge conflicts and
> provide precisely zero benefit. If you don't plan to be making any
> constructive changes to this file, then simply leave it alone.
--
Kristoffer Ericson <kristoffer.ericson@gmail.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-11-18 15:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-18 15:28 [PATCH] - Fix dreamcast irq.c formatting Kristoffer Ericson
2008-11-18 15:49 ` Paul Mundt
2008-11-18 15:53 ` Kristoffer Ericson [this message]
2008-11-18 15:57 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081118175424.19bc9a4b.kristoffer.ericson@gmail.com \
--to=kristoffer.ericson@gmail.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox