public inbox for linux-sh@vger.kernel.org
 help / color / mirror / Atom feed
From: Matt Fleming <mjf@gentoo.org>
To: linux-sh@vger.kernel.org
Subject: Re: HP Jornada 600-series bisected
Date: Tue, 25 Nov 2008 20:11:06 +0000	[thread overview]
Message-ID: <20081125201106.GB11884@console-pimps.org> (raw)
In-Reply-To: <20081120011600.9d3bf5cb.kristoffer.ericson@gmail.com>

On Tue, Nov 25, 2008 at 08:48:21PM +0100, Kristoffer Ericson wrote:
> 
> unsigned int hd64461_irq_demask(u16 mask)
> {
>     unsigned int i;
> 
> 	for (i = 1; i < 16; i++)
> 		if ((1 << i) & mask)
> 		break;
> 

Is there a reason that this starts from i = 1 and not i = 0?

> 
> void hd64461_irq_request(u16 mask, void (*fn)(int, void *), u16 trigger_mask)
> {
>     hd64461_irq_set_hand(mask, fn);
>     hd64461_irq_trigger(mask, trigger_mask);
>     hd64461_irq_enable(mask);
> }

I can't find any code in the kernel that registers with the current demux
code. Is this interface still necessary?


  parent reply	other threads:[~2008-11-25 20:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-19 23:15 HP Jornada 600-series bisected Kristoffer Ericson
2008-11-21  7:34 ` Paul Mundt
2008-11-21 10:08 ` Kristoffer Ericson
2008-11-22 16:49 ` Matt Fleming
2008-11-25 17:40 ` Kristoffer Ericson
2008-11-25 17:54 ` Paul Mundt
2008-11-25 18:47 ` Kristoffer Ericson
2008-11-25 19:50 ` Paul Mundt
2008-11-25 20:11 ` Matt Fleming [this message]
2008-11-25 20:19 ` Kristoffer Ericson
2008-11-25 20:26 ` Kristoffer Ericson
2008-11-27 19:02 ` Kristoffer Ericson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081125201106.GB11884@console-pimps.org \
    --to=mjf@gentoo.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox