Re: HP Jornada 600-series bisected

[Kristoffer Ericson <kristoffer.ericson@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2629 bytes --]

On Wed, 26 Nov 2008 04:50:11 +0900
Paul Mundt <lethal@linux-sh.org> wrote:

> On Tue, Nov 25, 2008 at 08:48:21PM +0100, Kristoffer Ericson wrote:
> > On Wed, 26 Nov 2008 02:54:26 +0900
> > Paul Mundt <lethal@linux-sh.org> wrote:
> > > Matt's patch should allow us to fix the __do_IRQ() problem, if you want
> > > to build on top of that, that is fine, but it is still helpful to know
> > > whether it works for you with CONFIG_GENERIC_HARDIRQS_NO__DO_IRQ enabled.
> > > 
> > > The only problematic thing I see is the lack of the base IRQ factoring,
> > > only the chained handlers for the multiplexed sources are defined. This
> > > is the way it should be, but it is possible that there will have to be
> > > another handler set up to at least get the hd64461 IRQ firing. This is
> > > the basis for that silly i == 16 thing in the old demux code. Any user
> > > that depends on that behaviour deserves to be broken, though.
> > 
> > I've attached the code I got so far. You can atleast see my 
> > approach to the issue.
> > 
> The approach you use has all of the same problems as the old code in
> terms of how the demux is handled and how it completely sidesteps the
> generic hardirq code. 

I must be missing something. Last time you said that there wasn't
much point in adding a virtual IRQ range, and thats what
I've been avoiding to do. Everything goes into the HD64461_IRQ
which simply sends "notifier"/runs interrupt of the
mask requesting it. Perhaps I misunderstod in what
way you wanted the mfd to notify the driver.

> Additionally, this is new code, rather than
> refactoring existing code. 

I can understand that changing existing code is better
than removing->adding new code. But I'm doing this
to get the pcmcia driver inside, which you said wouldn't
happen until the hd64461 was transformed into an MFD driver.
So on one side the hd64461 should be transformed into
an mfd driver and on the other existing approach should
be preserved.

> If Matt's patch doesn't work for you, then we
> just leave CONFIG_GENERIC_HARDIRQS_NO__DO_IRQ disabled for hd64461. If it
> does work however, then you are much better off adopting that code and
> including it in your MFD driver. The main thing is to fix what we have
> in-tree first.

I will test Matt's patch later today and see if it solves it,
It probably will. I mean no disrespect with my comments,
just that its frustrating missing your points all the time.
I don't do this for a living and medical studies doesn't
provide much of a + in these areas.

-- 
Kristoffer Ericson <kristoffer.ericson@gmail.com>

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]