Re: HP Jornada 600-series bisected

[Kristoffer Ericson <kristoffer.ericson@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1279 bytes --]

On Tue, 25 Nov 2008 20:11:06 +0000
Matt Fleming <mjf@gentoo.org> wrote:

> On Tue, Nov 25, 2008 at 08:48:21PM +0100, Kristoffer Ericson wrote:
> > 
> > unsigned int hd64461_irq_demask(u16 mask)
> > {
> >     unsigned int i;
> > 
> > 	for (i = 1; i < 16; i++)
> > 		if ((1 << i) & mask)
> > 		break;
> > 
> 
> Is there a reason that this starts from i = 1 and not i = 0?

Only 14,12,13,11,10,9,6,5 are actually reporting anything so
it could simply run from 5->14. But this 1->16 has been
used previously, most likely to just point out that
the register is 16bit. The reason I haven't changed it
is the fact that hd64465 got more sources, so locking it
down isn't a good idea.

> 
> > 
> > void hd64461_irq_request(u16 mask, void (*fn)(int, void *), u16 trigger_mask)
> > {
> >     hd64461_irq_set_hand(mask, fn);
> >     hd64461_irq_trigger(mask, trigger_mask);
> >     hd64461_irq_enable(mask);
> > }
> 
> I can't find any code in the kernel that registers with the current demux
> code. Is this interface still necessary?
> 
The idea is to use it in the coming hd64461 relevant code (pcmcia/fb/...) so
currently nothing is using it. The above code hasn't been applied anywhere.



-- 
Kristoffer Ericson <kristoffer.ericson@gmail.com>

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]