From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] Add plain udivsi3 (not _i4*) for gcc-4.1 and lower.
Date: Fri, 05 Dec 2008 11:41:20 +0000 [thread overview]
Message-ID: <20081205114119.GC14492@linux-sh.org> (raw)
In-Reply-To: <49389A5D.5040107@renesas.com>
On Fri, Dec 05, 2008 at 06:32:17PM +0900, Takashi Yoshii wrote:
> Nobuhiro Iwamatsu wrote:
> > Please use -C option.
> Wow! Amazing! .... but, result was not super good.
>
> What I got was a record doing
> mv udivsi3-Os.S udivsi3_i4i-Os.S; edit udivsi3_i4i-Os.S
> cp udivsi3.S udivsi3_i4i.S; edit udivsi3_i4i.S
> edit udivsi3.S
> while I did
> mv udivsi3-Os.S udivsi3_i4i-Os.S; edit udivsi3_i4i-Os.S
> mv udivsi3.S udivsi3_i4i.S; edit udivsi3_i4i.S
> create udivsi3.S
> .
>
> I known I can record them correctly in two commits, mvmv and create.
> I wonder if I should send two patch or no...
> Or, is there a way to do in one shot?
>
It is a bit difficult to see what precisely you changed given that the
changes are lost in the rename. If you do a rename first and then a
follow-up patch with your actual changes, then it is easier to see what
actually happened. Given that these are just from gcc directly though,
the changes aren't likely to be terribly interesting, so simply fixing
things up in a single change seems reasonable.
prev parent reply other threads:[~2008-12-05 11:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-05 3:05 [PATCH] Add plain udivsi3 (not _i4*) for gcc-4.1 and lower Takashi Yoshii
2008-12-05 4:23 ` morimoto.kuninori
2008-12-05 7:14 ` Nobuhiro Iwamatsu
2008-12-05 9:32 ` Takashi Yoshii
2008-12-05 11:41 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081205114119.GC14492@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox