Re: [PATCH RFC] sh: maple: Add support for SEGA Dreamcast VMU and

Adrian McMenamin
2009-01-29T10:34:43Z

On Thu, January 29, 2009 2:57 am, Paul Mundt wrote:
> On Thu, Jan 29, 2009 at 12:18:07AM +0000, Adrian McMenamin wrote:
>> + if (!(mdev->function & MAPLE_FUNC_KEYBOARD)) {
>> + error = EINVAL;
>> + goto fail;
>> + }
>>
> What is this all about? If the function doesn't match, you should never
> enter the probe routine in the first place. The bus code should already
> get this right.
>

It does, it is a fragment of old code from when the bus code was wrong
which for reasons which pass understanding I rewrote rather than just
excised.