Re: [PATCH RFC] sh: maple: Add support for SEGA Dreamcast VMU and clean up maple bus driver (3/3)

Paul Mundt
2009-01-29T02:57:54Z

On Thu, Jan 29, 2009 at 12:18:07AM +0000, Adrian McMenamin wrote:
> + if (!(mdev->function & MAPLE_FUNC_KEYBOARD)) {
> + error = EINVAL;
> + goto fail;
> + }
>
What is this all about? If the function doesn't match, you should never
enter the probe routine in the first place. The bus code should already
get this right.