public inbox for linux-sh@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 6/6] timer-tmu: Add SH7786 support
Date: Tue, 03 Mar 2009 06:44:39 +0000	[thread overview]
Message-ID: <20090303064439.GB30177@linux-sh.org> (raw)

On Fri, Feb 20, 2009 at 04:27:19PM +0900, Kuninori Morimoto wrote:
> L2 cache doesn't support now.
> This only support main cpu though sh7786 is multi core CPU.
> 
> Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com>

I've applied this series with a bit of tidying, but have done so as a
single changeset. If you wish to have this applied incrementally as a
series, each one of these patches need to build on the previous ones
incrementally, and no single patch should leave the tree in a broken
state. Splitting them up arbitrarily is not sufficient, as this breaks
bisection, which is not acceptable.

Please keep this in mind for future patches.

> diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
> index 78a01d7..0ae0968 100644
> --- a/arch/sh/Kconfig
> +++ b/arch/sh/Kconfig
> @@ -356,6 +356,13 @@ config CPU_SUBTYPE_SH7785
>  	select ARCH_SPARSEMEM_ENABLE
>  	select SYS_SUPPORTS_NUMA
>  
> +config CPU_SUBTYPE_SH7786
> +	bool "Support SH7786 processor"
> +	select CPU_SH4A
> +	select CPU_SHX2
> +	select ARCH_SPARSEMEM_ENABLE
> +	select SYS_SUPPORTS_NUMA
> +
>  config CPU_SUBTYPE_SHX3
>  	bool "Support SH-X3 processor"
>  	select CPU_SH4A

This is most definitely not an SH-X2 core, so this needs to be selecting
CPU_SHX3 instead. I'll take care of fixing that up though, since some of
the existing SH-X3 code really only applies to the SH-X3 proto CPUs, and
not to SH7786.

             reply	other threads:[~2009-03-03  6:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-03  6:44 Paul Mundt [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-02-20  7:02 [PATCH 6/6] timer-tmu: Add SH7786 support Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090303064439.GB30177@linux-sh.org \
    --to=lethal@linux-sh.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox