From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2] Add OHCI USB support for SH7786
Date: Thu, 05 Mar 2009 08:31:09 +0000 [thread overview]
Message-ID: <20090305083109.GA16451@linux-sh.org> (raw)
In-Reply-To: <uzlg2yu02.wl%morimoto.kuninori@renesas.com>
On Wed, Mar 04, 2009 at 07:51:12PM +0900, morimoto.kuninori@renesas.com wrote:
> > > + ? ? ? /*
> > > + ? ? ? ?* USB initial settings
> > > + ? ? ? ?*
> > > + ? ? ? ?* The following settings are necessary
> > > + ? ? ? ?* for using the USB modules.
> > > + ? ? ? ?*/
> > > + ? ? ? __raw_writel(0x00ff0040, 0xffe70094);
> > > + ? ? ? __raw_writel(0x00000001, 0xffe7009c);
> > > +
> > You forget to revise here.
>
> well... there are no name in these register,
> and there are no explanation about these value in manual.
> It just say do so.
> This is the reason why I didn't use MACRO here.
>
> But should I use MACRO ?
>
If this setting is needed, it needs to be documented. While getting a set
of register and value pairs from the hardware team is sufficient for
device bring-up, we can not maintain or debug this if we have no idea
what it is doing. Please confirm with the hardware team what this is
necessary for, we especially need to be aware of whether this is an
errata issue or not and whether this will continue to be necessary on
future cuts.
next prev parent reply other threads:[~2009-03-05 8:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 0:55 [PATCH v2] Add OHCI USB support for SH7786 Kuninori Morimoto
2009-03-04 1:37 ` Nobuhiro Iwamatsu
2009-03-04 10:51 ` morimoto.kuninori
2009-03-05 8:31 ` Paul Mundt [this message]
2009-03-06 5:13 ` morimoto.kuninori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090305083109.GA16451@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox