From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [Review request] sh-sci clock
Date: Tue, 14 Apr 2009 00:00:48 +0000 [thread overview]
Message-ID: <20090414000048.GA17618@linux-sh.org> (raw)
In-Reply-To: <ur5zxgnmk.wl%morimoto.kuninori@renesas.com>
On Mon, Apr 13, 2009 at 01:17:59PM +0900, Kuninori Morimoto wrote:
> diff --git a/drivers/serial/sh-sci.h b/drivers/serial/sh-sci.h
> index d0aa82d..5215b9d 100644
> --- a/drivers/serial/sh-sci.h
> +++ b/drivers/serial/sh-sci.h
> @@ -761,9 +761,9 @@ static inline int sci_rxd_in(struct uart_port *port)
> static inline int scbrr_calc(struct uart_port *port, int bps, int clk)
> {
> if (port->type = PORT_SCIF)
> - return (clk+16*bps)/(32*bps)-1;
> + return (clk/(32*bps))-1;
> else
> - return ((clk*2)+16*bps)/(16*bps)-1;
> + return (clk/(16*bps))-1;
> }
> #define SCBRR_VALUE(bps, clk) scbrr_calc(port, bps, clk)
> #elif defined(__H8300H__) || defined(__H8300S__)
This looks like an unrelated change, can you explain what this is about?
next prev parent reply other threads:[~2009-04-14 0:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-13 4:17 [Review request] sh-sci clock Kuninori Morimoto
2009-04-13 21:34 ` Paul Mundt
2009-04-14 0:00 ` Paul Mundt [this message]
2009-04-14 0:19 ` morimoto.kuninori
2009-04-14 2:08 ` morimoto.kuninori
2009-04-14 3:08 ` Paul Mundt
2009-04-14 5:01 ` morimoto.kuninori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090414000048.GA17618@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox