public inbox for linux-sh@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [RFC patch] sci_tx_empty for scif serial device
Date: Wed, 22 Apr 2009 00:34:17 +0000	[thread overview]
Message-ID: <20090422003417.GB23986@linux-sh.org> (raw)
In-Reply-To: <20090421120846.GA26186@gandalf.sssup.it>

On Tue, Apr 21, 2009 at 02:08:47PM +0200, Michael Trimarchi wrote:
> Add the sci_tx_empty function for scif serial device.
> 
> Signed-off-by: Michael Trimarchi <trimarchi@gandalf.sssup.it>
> ---
> diff --git a/drivers/serial/sh-sci.c b/drivers/serial/sh-sci.c
> index dbf5357..6cea2c4 100644
> --- a/drivers/serial/sh-sci.c
> +++ b/drivers/serial/sh-sci.c
> @@ -794,6 +794,20 @@ static void sci_free_irq(struct sci_port *port)
>  
>  static unsigned int sci_tx_empty(struct uart_port *port)
>  {
> +	int txroom = SCIF_TXROOM_MAX;
> +
> +#if defined(CONFIG_CPU_SUBTYPE_SH7763)
> +	if (!(port->mapbase = 0xffe00000) &&
> +	    !(port->mapbase = 0xffe08000)) {
> +		txroom = SCIF2_TXROOM_MAX)
> +	}
> +#endif

Uhm.. your version of gcc must be orders of magnitude more magical than
mine, as I see no way for this to compile :-)

> +	if (port->type = PORT_SCIF) {
> +		if (scif_txroom(port) = txroom)
> +			return TIOCSER_TEMT;
> +		return 0;
> +	}
> +
This looks ok anyways, is there some reason this can't be applied to
SH7763, too?

  reply	other threads:[~2009-04-22  0:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-21 12:08 [RFC patch] sci_tx_empty for scif serial device Michael Trimarchi
2009-04-22  0:34 ` Paul Mundt [this message]
2009-04-22  6:14 ` Michael Trimarchi
2009-04-22 11:33 ` Michael Trimarchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090422003417.GB23986@linux-sh.org \
    --to=lethal@linux-sh.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox