Re: [PATCH 1/1] r2dplus: add cfi flash support and enable it

[Paul Mundt <lethal@linux-sh.org>]

On Sun, Apr 26, 2009 at 06:42:42PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> +static struct resource flash_resource = {
> +	.start		= 0x00000000,
> +	.end		= 0x02000000,
> +	.flags		= IORESOURCE_MEM,
> +};
> +
> +static struct platform_device flash_device = {
> +	.name		= "physmap-flash",
> +	.id		= -1,
> +	.resource	= &flash_resource,
> +	.num_resources	= 1,
> +	.dev		= {
> +		.platform_data = &flash_data,
> +	},
> +};
> +
>  static struct platform_device *rts7751r2d_devices[] __initdata = {
>  	&sm501_device,
>  	&heartbeat_device,
>  	&spi_sh_sci_device,
> +	&flash_device,
>  };
>  
On RTS7751R2D-1 this is at least pretty bogus. By default the platform
has a socket-mounted MBM29F040 that is precisely 1MB, shadowed all the
way up to 0x04000000, with a fixed 16-bit bus width. There is the
possibility to hook up a larger flash to CN8 which will map directly over
top of that chip select space, but at least on RTS7751R2D-1, that is not
the default configuration.

I don't have an R2D+ manual handy at the moment, so I'll have to check
what the default configuration there is. We may have to conditionalize
the platform devices depending on revision of the board if they do in
fact ship with different flash configurations by default.