public inbox for linux-sh@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] Add ptrace support for NOMMU debugging
Date: Fri, 08 May 2009 18:28:51 +0000	[thread overview]
Message-ID: <200905081428.52464.vapier@gentoo.org> (raw)
In-Reply-To: <1241794254.16311.32.camel@quercus-bis>

[-- Attachment #1: Type: text/plain, Size: 785 bytes --]

On Friday 08 May 2009 10:50:54 Peter Griffin wrote:
> >From 2652ec6503dbe78e5bf371b77544e168166aa57d Mon Sep 17 00:00:00 2001
>
> From: Peter Griffin <pgriffin@mpc-data.co.uk>
> Date: Fri, 8 May 2009 15:01:21 +0100
> Subject: [PATCH] Add ptrace support for NOMMU debugging

are you not using git-send-email ?  posting the actual file produced by git-
format-patch looks weird (not sure if git-am works with this).

> +		else if ( addr == PT_TEXT_ADDR)
> +			tmp = child->mm->start_code;
> +		else if ( addr == PT_DATA_ADDR)
> +			tmp = child->mm->start_data;
> +		else if ( addr == PT_TEXT_END_ADDR )
> +			tmp = child->mm->end_code;
> +		else if ( addr == PT_TEXT_LEN )
> +			tmp = child->mm->end_code - child->mm->start_code;

style wrong: no space inside of those parenthesis
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2009-05-08 18:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-08 14:50 [PATCH] Add ptrace support for NOMMU debugging Peter Griffin
2009-05-08 18:28 ` Mike Frysinger [this message]
2009-05-12  8:38 ` Peter Griffin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200905081428.52464.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox