public inbox for linux-sh@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: ap325 camera without i2c driver fix
Date: Thu, 21 May 2009 17:45:21 +0000	[thread overview]
Message-ID: <20090521174521.GA2552@linux-sh.org> (raw)
In-Reply-To: <20090520143006.8314.55548.sendpatchset@rx1.opensource.se>

On Wed, May 20, 2009 at 11:30:06PM +0900, Magnus Damm wrote:
> This patch fixes the ap325rxa ncm03j camera code to handle
> the case where no i2c driver is present. Without this fix
> i2c_transfer() may be passed NULL as adapter which results
> in a crash.
> 
> Triggered when i2c-sh_mobile.c failed to probe() due to
> missing MSTP clocks.

On Wed, May 20, 2009 at 11:34:43PM +0900, Magnus Damm wrote:
> This patch fixes the LCDC driver to avoid calling the
> function sh_mobile_lcdc_start_stop(priv, 0) unless the
> same function has been called before to start the LCDC
> hardware.
> 
> Triggered when sh_mobile_lcdcfb.c failed to probe() due to
> missing MSTP clocks.

I was going to apply these, but as you provided no information as to what
branch these should be applied to, I didn't bother. Is this a problem
only in sh/clkfwk? Is this a problem with HEAD? Does it need to go in
2.6.30? If you are going to post a bunch of seemingly unrelated patches
in one go, it helps to know what exactly you want done with them.

  reply	other threads:[~2009-05-21 17:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-20 14:30 [PATCH] sh: ap325 camera without i2c driver fix Magnus Damm
2009-05-21 17:45 ` Paul Mundt [this message]
2009-05-22  4:14 ` Magnus Damm
2009-05-22  4:28 ` Paul Mundt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090521174521.GA2552@linux-sh.org \
    --to=lethal@linux-sh.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox