From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] usb: r8a66597-hcd: use platform_data instead of module_param
Date: Tue, 26 May 2009 03:22:21 +0000 [thread overview]
Message-ID: <20090526032221.GB9188@linux-sh.org> (raw)
In-Reply-To: <4A1B5D7C.6070205@renesas.com>
On Tue, May 26, 2009 at 12:09:48PM +0900, Yoshihiro Shimoda wrote:
> +struct r8a66597_platdata {
> + /* This ops can controll port power instead of DVSTCTR register. */
> + void (*port_power)(int port, int power);
> +
> + /* (external controller only) set R8A66597_PLATDATA_XTAL_nnMHZ */
> + unsigned xtal:2;
> +
> + /* set one = 3.3V, set zero = 1.5V */
> + unsigned vif:1;
> +
> + /* set one = big endian, set zero = little endian */
> + unsigned endian:1;
> +
> + /* set one = low level, set zero = falling edge */
> + unsigned irq_sense:1;
> +};
I would just get rid of irq_sense entirely. You can OR in
IRQF_TRIGGER_LOW or IRQF_TRIGGER_FALLING against IORESOURCE_IRQ in the
struct resource, so there is no need for reproducing this information
elsewhere.
next prev parent reply other threads:[~2009-05-26 3:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 3:09 [PATCH] usb: r8a66597-hcd: use platform_data instead of module_param Yoshihiro Shimoda
2009-05-26 3:22 ` Paul Mundt [this message]
2009-05-26 5:00 ` [PATCH] usb: r8a66597-hcd: use platform_data instead of Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090526032221.GB9188@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox