From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul Mundt <lethal@linux-sh.org>
Date: Tue, 26 May 2009 12:38:07 +0000
Subject: Re: [PATCH v2] usb: r8a66597-hcd: use platform_data instead of module_param
Message-Id: <20090526123806.GA17356@linux-sh.org>
List-Id: <linux-sh.vger.kernel.org>
References: <4A1BB552.3020909@renesas.com>
In-Reply-To: <4A1BB552.3020909@renesas.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: linux-sh@vger.kernel.org

On Tue, May 26, 2009 at 06:24:34PM +0900, Yoshihiro Shimoda wrote:
> CPU/board specific parameters (PLL clock, vif etc...) can be set
> by platform_data instead of module_param.
> 
> v2: remove irq_sense member in platform_data because it can OR in
>     IRQF_TRIGGER_LOW or IRQF_TRIGGER_FALLING against IORESOURCE_IRQ in
>     the struct resource.
> 
> Signed-off-by: Yoshihiro Shimoda <shimoda.yoshihiro@renesas.com>

Looks better!

Reviewed-by: Paul Mundt <lethal@linux-sh.org>