From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] usb: m66592-udc buffer management update
Date: Sat, 04 Jul 2009 15:37:39 +0000 [thread overview]
Message-ID: <20090704153738.GB9933@linux-sh.org> (raw)
On Fri, Jul 03, 2009 at 10:07:23AM -0700, Greg KH wrote:
> On Fri, Jul 03, 2009 at 05:37:47PM +0900, Paul Mundt wrote:
> > On Fri, Jul 03, 2009 at 05:34:41PM +0900, Yoshihiro Shimoda wrote:
> > > Yoshihiro Shimoda wrote:
> > > > Magnus Damm wrote:
> > > >> From: Magnus Damm <damm@igel.co.jp>
> > > >>
> > > >> This patch updates the m66592-udc buffer management code.
> > > >>
> > > >> Use fixed buffers for bulk and isochronous pipes, also make
> > > >> sure to handle the isochronous-as-bulk case. With fixed buffers
> > > >> there is no need to keep track of used buffers with bi_bufnum.
> > > >>
> > > >> Also, this fixes a potential buffer offset problem where the
> > > >> base offset incorrectly varies with the number of pipes used.
> > > >>
> > > >> With this patch applied it is possible to use m66592-udc for
> > > >> both Ethernet and Serial using CONFIG_USB_CDC_COMPOSITE.
> > > >>
> > > >> Signed-off-by: Magnus Damm <damm@igel.co.jp>
> > > >
> > > > Thank you for your patch.
> > > > I also thought that this management method was good.
> > > > In addition, thank you for finding a potential problem.
> > > > I tested this patch and confirmed it is working.
> > >
> > > I'm sorry. I forgot to write the Acked-by:
> > >
> > > Acked-by: Yoshihiro Shimoda <shimoda.yoshihiro@renesas.com>
> > >
> > Greg, any preferences? I was planning on just rolling this in to my
> > 2.6.32 queue unless you have any objections.
>
> No objection from me, please do so.
>
> Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
>
Done, thanks.
reply other threads:[~2009-07-04 15:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090704153738.GB9933@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox