From: Greg KH <gregkh@suse.de>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] usb: r8a66597-hcd platform data on_chip support
Date: Wed, 29 Jul 2009 13:05:32 +0000 [thread overview]
Message-ID: <20090729130532.GB27054@suse.de> (raw)
In-Reply-To: <20090717145955.17840.24106.sendpatchset@rx1.opensource.se>
On Wed, Jul 29, 2009 at 07:14:14PM +0900, Yoshihiro Shimoda wrote:
> Magnus Damm wrote:
> > From: Magnus Damm <damm@igel.co.jp>
> >
> > Convert the r8a66597-hcd driver to use the on_chip flag
> > from platform data to enable on chip behaviour instead
> > of relying on CONFIG_SUPERH_ON_CHIP_R8A66597 ugliness.
> >
> > This makes the code cleaner and also allows us to support
> > both external and internal r8a66597 with the same kernel.
> >
> > It also makes the Kconfig part more future proof since
> > we with this patch can add support for new processors
> > with on-chip r8a66597 without modifying the Kconfig.
> >
> > Signed-off-by: Magnus Damm <damm@igel.co.jp>
> > ---
>
> Thank you very much for your patch.
> I tested this patch and it was working.
>
> Acked-by: Yoshihiro Shimoda <shimoda.yoshihiro@renesas.com>
Thanks, I've added this to the patch.
greg k-h
prev parent reply other threads:[~2009-07-29 13:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-17 14:59 [PATCH] usb: r8a66597-hcd platform data on_chip support Magnus Damm
2009-07-29 10:14 ` Yoshihiro Shimoda
2009-07-29 13:05 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090729130532.GB27054@suse.de \
--to=gregkh@suse.de \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox