[PATCH] sh: USB0 resource area fix for ms7724se

[PATCH] sh: USB0 resource area fix for ms7724se

[Kuninori Morimoto]

Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com>
---
Magnus

in 15 Apr 2009, "Re: [PATCH 3/6] Add USB support for SH7724"
you taught me about USB area miss. (do you remember ?)
I think this is just your mistake. or is there any reason ?

 arch/sh/boards/mach-se/7724/setup.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/sh/boards/mach-se/7724/setup.c b/arch/sh/boards/mach-se/7724/setup.c
index 9162081..c04e134 100644
--- a/arch/sh/boards/mach-se/7724/setup.c
+++ b/arch/sh/boards/mach-se/7724/setup.c
@@ -319,7 +319,7 @@ static struct r8a66597_platdata sh7724_usb0_host_data = {
 static struct resource sh7724_usb0_host_resources[] = {
 	[0] = {
 		.start	= 0xa4d80000,
-		.end	= 0xa4d800ff,
+		.end	= 0xa4d80124 - 1,
 		.flags	= IORESOURCE_MEM,
 	},
 	[1] = {
-- 
1.6.0.4

Re: [PATCH] sh: USB0 resource area fix for ms7724se

[Magnus Damm]

On Wed, Aug 19, 2009 at 9:12 AM, Kuninori
Morimoto<morimoto.kuninori@renesas.com> wrote:
>
> Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com>
> ---
> Magnus
>
> in 15 Apr 2009, "Re: [PATCH 3/6] Add USB support for SH7724"
> you taught me about USB area miss. (do you remember ?)
> I think this is just your mistake. or is there any reason ?

You are correct. But please fix other boards and processors using the
same driver!

> --- a/arch/sh/boards/mach-se/7724/setup.c
> +++ b/arch/sh/boards/mach-se/7724/setup.c
> @@ -319,7 +319,7 @@ static struct r8a66597_platdata sh7724_usb0_host_data = {
>  static struct resource sh7724_usb0_host_resources[] = {
>        [0] = {
>                .start  = 0xa4d80000,
> -               .end    = 0xa4d800ff,
> +               .end    = 0xa4d80124 - 1,

Correct but not so pretty with "- 1" in my opinion.

Thanks for your help!

/ magnus

Re: [PATCH] sh: USB0 resource area fix for ms7724se

[Kuninori Morimoto]

Hi Magnus

> > I think this is just your mistake. or is there any reason ?
> 
> You are correct. But please fix other boards and processors using the
> same driver!

I think strange register is SH7724 only.
And the SH7724 board which use USB host is ms7724se only now.

Best regards
--
Kuninori Morimoto

Re: [PATCH] sh: USB0 resource area fix for ms7724se

[Magnus Damm]

On Wed, Aug 19, 2009 at 7:16 PM, Kuninori
Morimoto<morimoto.kuninori@renesas.com> wrote:
> I think strange register is SH7724 only.
> And the SH7724 board which use USB host is ms7724se only now.

Ok, I see. The driver does not seem to use this register at this point
so the change is mainly cosmetic.

Cheers,

/ magnus

Re: [PATCH] sh: USB0 resource area fix for ms7724se

[Paul Mundt]

On Wed, Aug 19, 2009 at 09:12:15AM +0900, Kuninori Morimoto wrote:
> 
> Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com>
> ---
> Magnus
> 
> in 15 Apr 2009, "Re: [PATCH 3/6] Add USB support for SH7724"
> you taught me about USB area miss. (do you remember ?)
> I think this is just your mistake. or is there any reason ?
> 
>  arch/sh/boards/mach-se/7724/setup.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 

On Wed, Aug 19, 2009 at 07:24:15PM +0900, Kuninori Morimoto wrote:
> This patch also update help comment
> 
> Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com>
> ---
>  arch/sh/drivers/dma/Kconfig |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
applied, thanks.