From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: Kuninori Morimoto <morimoto.kuninori@renesas.com>,
Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, lethal@linux-sh.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH 3/3] Add FSI-AK464x sound support for ms7724se
Date: Wed, 19 Aug 2009 14:02:56 +0000 [thread overview]
Message-ID: <20090819140256.GA31305@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <aec7e5c30908190646l1af450e8w3178683893a17437@mail.gmail.com>
On Wed, Aug 19, 2009 at 10:46:34PM +0900, Magnus Damm wrote:
> On Wed, Aug 19, 2009 at 9:00 PM, Mark
> Brown<broonie@opensource.wolfsonmicro.com> wrote:
> >> + gpio_request(GPIO_FN_FSIMCKA, NULL);
> > Is this something that the FSI driver should do for itself? It looks
> > like there's no pin options here, just fixed functions for FSI A or B so
> > replicating per-board seems redundant. On the other hand, if it's
> > idiomatic for SH better keep it this way.
> These GPIO_FN_ values are processor specific, sh7724 in this case. I
> suspect we will see the FSI block reused in future processors so
> keeping processor-specific bits out of the driver itself may be a good
> plan. Long term I'd be more than happy to pass along processors
> specific GPIOs to each driver, but at this point I don't know any
> clean and standard way to do that.
Is it possible to build kernels for more than one processor? The way
the code looks that's not the case...
next prev parent reply other threads:[~2009-08-19 14:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-19 11:25 [PATCH 3/3] Add FSI-AK464x sound support for ms7724se Kuninori Morimoto
2009-08-19 12:00 ` Mark Brown
2009-08-19 13:46 ` Magnus Damm
2009-08-19 14:02 ` Mark Brown [this message]
2009-08-19 14:18 ` Magnus Damm
2009-08-19 14:45 ` Mark Brown
2009-08-20 7:46 ` [alsa-devel] " Kuninori Morimoto
2009-08-20 8:52 ` [alsa-devel] [PATCH 3/3] Add FSI-AK464x sound support for Mark Brown
2009-08-20 11:48 ` [alsa-devel] [PATCH 3/3] Add FSI-AK464x sound support for ms7724se Kuninori Morimoto
2009-08-20 11:55 ` [alsa-devel] [PATCH 3/3] Add FSI-AK464x sound support for Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090819140256.GA31305@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=morimoto.kuninori@renesas.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox