From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Date: Wed, 19 Aug 2009 14:02:56 +0000 Subject: Re: [PATCH 3/3] Add FSI-AK464x sound support for ms7724se Message-Id: <20090819140256.GA31305@rakim.wolfsonmicro.main> List-Id: References: <20090819120058.GB20227@rakim.wolfsonmicro.main> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Magnus Damm Cc: Kuninori Morimoto , Takashi Iwai , alsa-devel@alsa-project.org, lethal@linux-sh.org, linux-sh@vger.kernel.org On Wed, Aug 19, 2009 at 10:46:34PM +0900, Magnus Damm wrote: > On Wed, Aug 19, 2009 at 9:00 PM, Mark > Brown wrote: > >> + =A0 =A0 gpio_request(GPIO_FN_FSIMCKA, =A0 =A0NULL); > > Is this something that the FSI driver should do for itself? =A0It looks > > like there's no pin options here, just fixed functions for FSI A or B so > > replicating per-board seems redundant. =A0On the other hand, if it's > > idiomatic for SH better keep it this way. > These GPIO_FN_ values are processor specific, sh7724 in this case. I > suspect we will see the FSI block reused in future processors so > keeping processor-specific bits out of the driver itself may be a good > plan. Long term I'd be more than happy to pass along processors > specific GPIOs to each driver, but at this point I don't know any > clean and standard way to do that. Is it possible to build kernels for more than one processor? The way the code looks that's not the case...