From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: Kuninori Morimoto <morimoto.kuninori@renesas.com>,
Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, lethal@linux-sh.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/3] Add SuperH FSI driver support for ALSA
Date: Wed, 19 Aug 2009 14:44:20 +0000 [thread overview]
Message-ID: <20090819144420.GA3323@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <aec7e5c30908190659n4b81272ek6e06f23f4ee71a15@mail.gmail.com>
On Wed, Aug 19, 2009 at 10:59:56PM +0900, Magnus Damm wrote:
> > +struct fsi_master *master;
> Is it really necessary to have "master" as a global variable? Maybe
> this global variable is there to work around some framework issue?
There's no ASoC reason for doing this. Anything that needs to be shared
between different DAIs can always be shared via the DMA driver.
Looking at the driver I rather suspect it only supports one FSI at once
and the capture support is also incomplete. I don't see much problem
merging the driver with these limitations, it's generally been much
easier to get people to fix problems with merged drivers than to get
people to contribute entirely new drivers.
next prev parent reply other threads:[~2009-08-19 14:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-19 11:25 [PATCH 1/3] Add SuperH FSI driver support for ALSA Kuninori Morimoto
2009-08-19 12:28 ` Mark Brown
2009-08-19 12:39 ` Takashi Iwai
2009-08-19 12:42 ` Mark Brown
2009-08-19 13:59 ` Magnus Damm
2009-08-19 14:44 ` Mark Brown [this message]
2009-08-20 12:11 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090819144420.GA3323@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=morimoto.kuninori@renesas.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox