linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] sh: Do not apply virt_to_phys() to a physical address
@ 2009-10-29 21:53 Matt Fleming
  2009-10-30  3:37 ` Paul Mundt
  0 siblings, 1 reply; 2+ messages in thread
From: Matt Fleming @ 2009-10-29 21:53 UTC (permalink / raw)
  To: linux-sh

The variable 'phys' already contains the physical address to flush. It
is not a virtual address and should not be passed to virt_to_phys().

Signed-off-by: Matt Fleming <matt@console-pimps.org>
---
 arch/sh/mm/cache-sh4.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/sh/mm/cache-sh4.c b/arch/sh/mm/cache-sh4.c
index 4a2fbf2..b5abe94 100644
--- a/arch/sh/mm/cache-sh4.c
+++ b/arch/sh/mm/cache-sh4.c
@@ -95,8 +95,7 @@ static inline void flush_cache_one(unsigned long start, unsigned long phys)
 		exec_offset = cached_to_uncached;
 
 	local_irq_save(flags);
-	__flush_cache_one(start | SH_CACHE_ASSOC,
-			  virt_to_phys(phys), exec_offset);
+	__flush_cache_one(start | SH_CACHE_ASSOC, phys, exec_offset);
 	local_irq_restore(flags);
 }
 
-- 
1.6.2.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] sh: Do not apply virt_to_phys() to a physical address
  2009-10-29 21:53 [PATCH] sh: Do not apply virt_to_phys() to a physical address Matt Fleming
@ 2009-10-30  3:37 ` Paul Mundt
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Mundt @ 2009-10-30  3:37 UTC (permalink / raw)
  To: linux-sh

On Thu, Oct 29, 2009 at 09:53:30PM +0000, Matt Fleming wrote:
> The variable 'phys' already contains the physical address to flush. It
> is not a virtual address and should not be passed to virt_to_phys().
> 
> Signed-off-by: Matt Fleming <matt@console-pimps.org>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-10-30  3:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-29 21:53 [PATCH] sh: Do not apply virt_to_phys() to a physical address Matt Fleming
2009-10-30  3:37 ` Paul Mundt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).