public inbox for linux-sh@vger.kernel.org
 help / color / mirror / Atom feed
From: Matt Fleming <matt@console-pimps.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: Account for cache aliases in flush_icache_range()
Date: Fri, 06 Nov 2009 08:02:46 +0000	[thread overview]
Message-ID: <20091106080246.GA19266@console-pimps.org> (raw)
In-Reply-To: <1257462879-16865-1-git-send-email-matt@console-pimps.org>

On Thu, Nov 05, 2009 at 11:14:39PM +0000, Matt Fleming wrote:
> The icache may also contain aliases so we must account for them just
> like we do when manipulating the dcache. We usually get away with
> aliases in the icache because the instructions that are read from memory
> are read-only, i.e. they never change. However, the place where this
> bites us is when the code has been modified.
> 

Just to be clear, I haven't actually seen any errors because of this
code. But the fix looks correct to me unless we're never in a state
where we have aliases in the icache (even though in theory we could)?

  reply	other threads:[~2009-11-06  8:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-05 23:14 [PATCH] sh: Account for cache aliases in flush_icache_range() Matt Fleming
2009-11-06  8:02 ` Matt Fleming [this message]
2009-11-09  1:49 ` Paul Mundt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091106080246.GA19266@console-pimps.org \
    --to=matt@console-pimps.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox