From: Paul Mundt <lethal@linux-sh.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-kernel@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH 2/3 v2] sh: fix DMA driver's descriptor chaining and cookie assignment
Date: Fri, 11 Dec 2009 08:02:54 +0000 [thread overview]
Message-ID: <20091211080254.GB7625@linux-sh.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0912101833170.4487@axis700.grange>
On Thu, Dec 10, 2009 at 06:35:11PM +0100, Guennadi Liakhovetski wrote:
> The SH DMA driver wrongly assigns negative cookies to transfer descriptors,
> also, its chaining of partial descriptors is broken. The latter problem is
> usually invisible, because maximum transfer size per chunk is 16M, but if you
> artificially set this limit lower, the driver fails. Since cookies are also
> used in chunk management, both these problems are fixed in one patch. As side
> effects a possible memory leak, when descriptors are prepared, but not
> submitted, and multiple races have also been fixed.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Looks good to me.
Acked-by: Paul Mundt <lethal@linux-sh.org>
next prev parent reply other threads:[~2009-12-11 8:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-10 17:35 [PATCH 0/3 v2] sh: fix dma driver Guennadi Liakhovetski
2009-12-10 17:35 ` [PATCH 1/3 v2] sh: stylistic improvements for the DMA driver Guennadi Liakhovetski
2009-12-10 17:35 ` [PATCH 2/3 v2] sh: fix DMA driver's descriptor chaining and cookie Guennadi Liakhovetski
2009-12-11 8:02 ` Paul Mundt [this message]
2009-12-12 2:15 ` [PATCH 2/3 v2] sh: fix DMA driver's descriptor chaining and Nobuhiro Iwamatsu
2009-12-17 3:09 ` Nobuhiro Iwamatsu
2009-12-17 7:40 ` Guennadi Liakhovetski
2009-12-17 8:33 ` Nobuhiro Iwamatsu
2009-12-17 8:43 ` Guennadi Liakhovetski
2009-12-17 17:50 ` Dan Williams
2009-12-10 17:35 ` [PATCH 3/3] dmaengine: clarify the meaning of the DMA_CTRL_ACK flag Guennadi Liakhovetski
2009-12-12 4:58 ` [PATCH 0/3 v2] sh: fix dma driver Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091211080254.GB7625@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=dan.j.williams@intel.com \
--cc=g.liakhovetski@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).