* [PATCH] sh: Fix test of unsigned in se7722_irq_demux()
@ 2009-12-15 16:36 Roel Kluin
2009-12-16 4:27 ` Paul Mundt
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-12-15 16:36 UTC (permalink / raw)
To: Paul Mundt, linux-sh, Andrew Morton, LKML
se7722_fpga_irq[] is unsigned so the test does not work.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Found using coccinelle: http://coccinelle.lip6.fr/
diff --git a/arch/sh/boards/mach-se/7722/irq.c b/arch/sh/boards/mach-se/7722/irq.c
index 4eb31ac..b221b68 100644
--- a/arch/sh/boards/mach-se/7722/irq.c
+++ b/arch/sh/boards/mach-se/7722/irq.c
@@ -57,15 +57,16 @@ static void se7722_irq_demux(unsigned int irq, struct irq_desc *desc)
*/
void __init init_se7722_IRQ(void)
{
- int i;
+ int i, irq;
ctrl_outw(0, IRQ01_MASK); /* disable all irqs */
ctrl_outw(0x2000, 0xb03fffec); /* mrshpc irq enable */
for (i = 0; i < SE7722_FPGA_IRQ_NR; i++) {
- se7722_fpga_irq[i] = create_irq();
- if (se7722_fpga_irq[i] < 0)
+ irq = create_irq();
+ if (irq < 0)
return;
+ se7722_fpga_irq[i] = irq;
set_irq_chip_and_handler_name(se7722_fpga_irq[i],
&se7722_irq_chip,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sh: Fix test of unsigned in se7722_irq_demux()
2009-12-15 16:36 [PATCH] sh: Fix test of unsigned in se7722_irq_demux() Roel Kluin
@ 2009-12-16 4:27 ` Paul Mundt
0 siblings, 0 replies; 2+ messages in thread
From: Paul Mundt @ 2009-12-16 4:27 UTC (permalink / raw)
To: Roel Kluin; +Cc: linux-sh, Andrew Morton, LKML
On Tue, Dec 15, 2009 at 05:36:34PM +0100, Roel Kluin wrote:
> se7722_fpga_irq[] is unsigned so the test does not work.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> Found using coccinelle: http://coccinelle.lip6.fr/
>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-16 4:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-15 16:36 [PATCH] sh: Fix test of unsigned in se7722_irq_demux() Roel Kluin
2009-12-16 4:27 ` Paul Mundt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).