From: Samuel Ortiz <sameo@linux.intel.com>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
SH-Linux <linux-sh@vger.kernel.org>,
Ian Molton <ian@mnementh.co.uk>
Subject: Re: v2.6.33-rc2 build error - missing tmio mmc patches
Date: Mon, 04 Jan 2010 13:45:38 +0000 [thread overview]
Message-ID: <20100104134537.GA5394@sortiz.org> (raw)
In-Reply-To: <aec7e5c30912280011j4e8528e5r34bc1bcfb6a4dd1a@mail.gmail.com>
Hi Magnus,
On Mon, Dec 28, 2009 at 05:11:27PM +0900, Magnus Damm wrote:
> Hi everyone,
>
> v2.6.33-rc2 does not build in the case of CONFIG_MFD_SH_MOBILE_SDHI=y.
> Linux-next used to build just fine when I developed the driver, but
> now it looks like some tmio-mmc patches present in linux-next never
> made it into -rc.
>
> CC drivers/mfd/sh_mobile_sdhi.o
> drivers/mfd/sh_mobile_sdhi.c: In function 'sh_mobile_sdhi_probe':
> drivers/mfd/sh_mobile_sdhi.c:100: error: 'struct tmio_mmc_data' has no
> member named 'set_pwr'
> make[2]: *** [drivers/mfd/sh_mobile_sdhi.o] Error 1
>
> In more detail, the missing patch is here:
> http://git.mnementh.co.uk/cgi-bin/gitweb.cgi?p=linux-2.6-im.git;a=commitdiff;hLd83bd05e6c817a4a72ababd82bf5ae700c021d
>
> What needs to be done to get the patch above included in rc3? Is there
> anything I can do?
Ian assumed anything that was in linux-next was being pulled by Linus
automatically. That's why this code is not there.
Could you or Ian please submit this patch to linux-kernel and me. If it's all
fine, I'll carry it with my next .33 fixes.
Cheers,
Samuel.
> Thanks,
>
> / magnus
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2010-01-04 13:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-28 8:11 v2.6.33-rc2 build error - missing tmio mmc patches Magnus Damm
2010-01-04 13:45 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100104134537.GA5394@sortiz.org \
--to=sameo@linux.intel.com \
--cc=ian@mnementh.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).