v2.6.33-rc2 build error - missing tmio mmc patches

v2.6.33-rc2 build error - missing tmio mmc patches

[Magnus Damm]

Hi everyone,

v2.6.33-rc2 does not build in the case of CONFIG_MFD_SH_MOBILE_SDHI=y.
Linux-next used to build just fine when I developed the driver, but
now it looks like some tmio-mmc patches present in linux-next never
made it into -rc.

  CC      drivers/mfd/sh_mobile_sdhi.o
drivers/mfd/sh_mobile_sdhi.c: In function 'sh_mobile_sdhi_probe':
drivers/mfd/sh_mobile_sdhi.c:100: error: 'struct tmio_mmc_data' has no
member named 'set_pwr'
make[2]: *** [drivers/mfd/sh_mobile_sdhi.o] Error 1

In more detail, the missing patch is here:
http://git.mnementh.co.uk/cgi-bin/gitweb.cgi?p=linux-2.6-im.git;a=commitdiff;hLd83bd05e6c817a4a72ababd82bf5ae700c021d

What needs to be done to get the patch above included in rc3? Is there
anything I can do?

Thanks,

/ magnus

Re: v2.6.33-rc2 build error - missing tmio mmc patches

[Samuel Ortiz]

Hi Magnus,

On Mon, Dec 28, 2009 at 05:11:27PM +0900, Magnus Damm wrote:
> Hi everyone,
> 
> v2.6.33-rc2 does not build in the case of CONFIG_MFD_SH_MOBILE_SDHI=y.
> Linux-next used to build just fine when I developed the driver, but
> now it looks like some tmio-mmc patches present in linux-next never
> made it into -rc.
> 
>   CC      drivers/mfd/sh_mobile_sdhi.o
> drivers/mfd/sh_mobile_sdhi.c: In function 'sh_mobile_sdhi_probe':
> drivers/mfd/sh_mobile_sdhi.c:100: error: 'struct tmio_mmc_data' has no
> member named 'set_pwr'
> make[2]: *** [drivers/mfd/sh_mobile_sdhi.o] Error 1
> 
> In more detail, the missing patch is here:
> http://git.mnementh.co.uk/cgi-bin/gitweb.cgi?p=linux-2.6-im.git;a=commitdiff;hLd83bd05e6c817a4a72ababd82bf5ae700c021d
> 
> What needs to be done to get the patch above included in rc3? Is there
> anything I can do?
Ian assumed anything that was in linux-next was being pulled by Linus
automatically. That's why this code is not there.
Could you or Ian please submit this patch to linux-kernel and me. If it's all
fine, I'll carry it with my next .33 fixes.

Cheers,
Samuel.


> Thanks,
> 
> / magnus

-- 
Intel Open Source Technology Centre
http://oss.intel.com/