From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] spi_sh_msiof: Fixed data sampling on the correct edge
Date: Wed, 27 Jan 2010 07:27:14 +0000 [thread overview]
Message-ID: <20100127072713.GH2739@linux-sh.org> (raw)
In-Reply-To: <95F51F4B902CAC40AF459205F6322F0171E8D4959B@BMK019S01.emtrion.local>
On Wed, Jan 27, 2010 at 04:23:36PM +0900, Magnus Damm wrote:
> On Thu, Jan 21, 2010 at 7:28 PM, Pietrek, Markus
> <Markus.Pietrek@emtrion.de> wrote:
> > I'm using spidev to communicate with a samsung oled display S6E63D6.
> > This display requires the mode SPI_CPHA and SPI_CPOL.
> >
> > Plain writing is fine with the old register setting (REDG=!TEDG). I
> > can configure the display. But when reading the chip identifier, the
> > last byte (of the identified 0x63D6) is never stored in the FIFO. I
> > always read 0x6363, so the FIFO returns the 2nd last byte as the last
> > byte.
>
> Huh, is that so?
>
> I tested this on my Ecovec sh7724 board with MMC-over-SPI and your
> patch does not break my setup...
>
> > With a logical analyzer I can proof that the device is sending the
> > correct data. So it must be an issue of the sampling. And changing
> > REDG/TEDG to the values recommended in the SH7723 HW Reference Manual
> > fixed this issue.
>
> .. and following the data sheet sounds like a good plan. Especially
> since it fixes your issue.
>
> Can you please send a patch without the debug printouts to
> spi-devel-general and add my acked-by?
>
> Acked-by: Magnus Damm <damm@opensource.se>
>
This looks like something we should handle for 2.6.33 anyways, so Markus
when you resubmit this make sure to provide your Signed-off-by as well,
then I'll batch it up with the next round of updates, thanks.
prev parent reply other threads:[~2010-01-27 7:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 9:26 [PATCH] spi_sh_msiof: Fixed data sampling on the correct edge Pietrek, Markus
2010-01-21 10:01 ` Magnus Damm
2010-01-21 10:28 ` AW: " Pietrek, Markus
2010-01-27 7:23 ` Magnus Damm
2010-01-27 7:27 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100127072713.GH2739@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).