* [PATCH] ARM: mach-shmobile: pfc-sh7377: modify KEYIN settings
@ 2010-02-19 7:52 Kuninori Morimoto
2010-02-22 7:32 ` NISHIMOTO Hiroki
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Kuninori Morimoto @ 2010-02-19 7:52 UTC (permalink / raw)
To: linux-sh
Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com>
---
arch/arm/mach-shmobile/pfc-sh7377.c | 17 +++++++++--------
1 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/arch/arm/mach-shmobile/pfc-sh7377.c b/arch/arm/mach-shmobile/pfc-sh7377.c
index 79b53d8..613e684 100644
--- a/arch/arm/mach-shmobile/pfc-sh7377.c
+++ b/arch/arm/mach-shmobile/pfc-sh7377.c
@@ -102,6 +102,7 @@ enum {
PORT_265(FN7), /* PORT0_FN7 -> PORT264_FN7 */
MSELBCR_MSEL17_1, MSELBCR_MSEL17_0,
+ MSELBCR_MSEL16_1, MSELBCR_MSEL16_0,
PINMUX_FUNCTION_END,
PINMUX_MARK_BEGIN,
@@ -528,19 +529,19 @@ static pinmux_enum_t pinmux_data[] = {
PORT_DATA_IO_PU_PD(263),
/* Special Pull-up / Pull-down Functions */
- PINMUX_DATA(PORT66_KEYIN0_PU_MARK, MSELBCR_MSEL17_0,
+ PINMUX_DATA(PORT66_KEYIN0_PU_MARK, MSELBCR_MSEL17_0, MSELBCR_MSEL16_0,
PORT66_FN2, PORT66_IN_PU),
- PINMUX_DATA(PORT67_KEYIN1_PU_MARK, MSELBCR_MSEL17_0,
+ PINMUX_DATA(PORT67_KEYIN1_PU_MARK, MSELBCR_MSEL17_0, MSELBCR_MSEL16_0,
PORT67_FN2, PORT67_IN_PU),
- PINMUX_DATA(PORT68_KEYIN2_PU_MARK, MSELBCR_MSEL17_0,
+ PINMUX_DATA(PORT68_KEYIN2_PU_MARK, MSELBCR_MSEL17_0, MSELBCR_MSEL16_0,
PORT68_FN2, PORT68_IN_PU),
- PINMUX_DATA(PORT69_KEYIN3_PU_MARK, MSELBCR_MSEL17_0,
+ PINMUX_DATA(PORT69_KEYIN3_PU_MARK, MSELBCR_MSEL17_0, MSELBCR_MSEL16_0,
PORT69_FN2, PORT69_IN_PU),
- PINMUX_DATA(PORT70_KEYIN4_PU_MARK, MSELBCR_MSEL17_0,
+ PINMUX_DATA(PORT70_KEYIN4_PU_MARK, MSELBCR_MSEL17_0, MSELBCR_MSEL16_0,
PORT70_FN2, PORT70_IN_PU),
- PINMUX_DATA(PORT71_KEYIN5_PU_MARK, MSELBCR_MSEL17_0,
+ PINMUX_DATA(PORT71_KEYIN5_PU_MARK, MSELBCR_MSEL17_0, MSELBCR_MSEL16_0,
PORT71_FN2, PORT71_IN_PU),
- PINMUX_DATA(PORT72_KEYIN6_PU_MARK, MSELBCR_MSEL17_0,
+ PINMUX_DATA(PORT72_KEYIN6_PU_MARK, MSELBCR_MSEL17_0, MSELBCR_MSEL16_0,
PORT72_FN2, PORT72_IN_PU),
@@ -1637,7 +1638,7 @@ static struct pinmux_cfg_reg pinmux_config_regs[] = {
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
MSELBCR_MSEL17_0, MSELBCR_MSEL17_1,
- 0, 0,
+ MSELBCR_MSEL16_0, MSELBCR_MSEL16_1,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 }
},
--
1.6.3.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: mach-shmobile: pfc-sh7377: modify KEYIN settings
2010-02-19 7:52 [PATCH] ARM: mach-shmobile: pfc-sh7377: modify KEYIN settings Kuninori Morimoto
@ 2010-02-22 7:32 ` NISHIMOTO Hiroki
2010-02-22 7:41 ` Paul Mundt
2010-02-23 0:58 ` NISHIMOTO Hiroki
2 siblings, 0 replies; 4+ messages in thread
From: NISHIMOTO Hiroki @ 2010-02-22 7:32 UTC (permalink / raw)
To: linux-sh
I tested this patch and found that it made the keysc behavior worse.
Please stop applying the patch.
I will investigate the cause of the issue and send a patch latar.
thanks,
Kuninori Morimoto さんは書きました:
> Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com>
> ---
> arch/arm/mach-shmobile/pfc-sh7377.c | 17 +++++++++--------
> 1 files changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/mach-shmobile/pfc-sh7377.c b/arch/arm/mach-shmobile/pfc-sh7377.c
> index 79b53d8..613e684 100644
> --- a/arch/arm/mach-shmobile/pfc-sh7377.c
> +++ b/arch/arm/mach-shmobile/pfc-sh7377.c
> @@ -102,6 +102,7 @@ enum {
> PORT_265(FN7), /* PORT0_FN7 -> PORT264_FN7 */
>
> MSELBCR_MSEL17_1, MSELBCR_MSEL17_0,
> + MSELBCR_MSEL16_1, MSELBCR_MSEL16_0,
> PINMUX_FUNCTION_END,
>
> PINMUX_MARK_BEGIN,
> @@ -528,19 +529,19 @@ static pinmux_enum_t pinmux_data[] = {
> PORT_DATA_IO_PU_PD(263),
>
> /* Special Pull-up / Pull-down Functions */
> - PINMUX_DATA(PORT66_KEYIN0_PU_MARK, MSELBCR_MSEL17_0,
> + PINMUX_DATA(PORT66_KEYIN0_PU_MARK, MSELBCR_MSEL17_0, MSELBCR_MSEL16_0,
> PORT66_FN2, PORT66_IN_PU),
> - PINMUX_DATA(PORT67_KEYIN1_PU_MARK, MSELBCR_MSEL17_0,
> + PINMUX_DATA(PORT67_KEYIN1_PU_MARK, MSELBCR_MSEL17_0, MSELBCR_MSEL16_0,
> PORT67_FN2, PORT67_IN_PU),
> - PINMUX_DATA(PORT68_KEYIN2_PU_MARK, MSELBCR_MSEL17_0,
> + PINMUX_DATA(PORT68_KEYIN2_PU_MARK, MSELBCR_MSEL17_0, MSELBCR_MSEL16_0,
> PORT68_FN2, PORT68_IN_PU),
> - PINMUX_DATA(PORT69_KEYIN3_PU_MARK, MSELBCR_MSEL17_0,
> + PINMUX_DATA(PORT69_KEYIN3_PU_MARK, MSELBCR_MSEL17_0, MSELBCR_MSEL16_0,
> PORT69_FN2, PORT69_IN_PU),
> - PINMUX_DATA(PORT70_KEYIN4_PU_MARK, MSELBCR_MSEL17_0,
> + PINMUX_DATA(PORT70_KEYIN4_PU_MARK, MSELBCR_MSEL17_0, MSELBCR_MSEL16_0,
> PORT70_FN2, PORT70_IN_PU),
> - PINMUX_DATA(PORT71_KEYIN5_PU_MARK, MSELBCR_MSEL17_0,
> + PINMUX_DATA(PORT71_KEYIN5_PU_MARK, MSELBCR_MSEL17_0, MSELBCR_MSEL16_0,
> PORT71_FN2, PORT71_IN_PU),
> - PINMUX_DATA(PORT72_KEYIN6_PU_MARK, MSELBCR_MSEL17_0,
> + PINMUX_DATA(PORT72_KEYIN6_PU_MARK, MSELBCR_MSEL17_0, MSELBCR_MSEL16_0,
> PORT72_FN2, PORT72_IN_PU),
>
>
> @@ -1637,7 +1638,7 @@ static struct pinmux_cfg_reg pinmux_config_regs[] = {
> 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
> 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
> MSELBCR_MSEL17_0, MSELBCR_MSEL17_1,
> - 0, 0,
> + MSELBCR_MSEL16_0, MSELBCR_MSEL16_1,
> 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
> 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 }
> },
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: mach-shmobile: pfc-sh7377: modify KEYIN settings
2010-02-19 7:52 [PATCH] ARM: mach-shmobile: pfc-sh7377: modify KEYIN settings Kuninori Morimoto
2010-02-22 7:32 ` NISHIMOTO Hiroki
@ 2010-02-22 7:41 ` Paul Mundt
2010-02-23 0:58 ` NISHIMOTO Hiroki
2 siblings, 0 replies; 4+ messages in thread
From: Paul Mundt @ 2010-02-22 7:41 UTC (permalink / raw)
To: linux-sh
On Mon, Feb 22, 2010 at 04:32:28PM +0900, NISHIMOTO Hiroki wrote:
> I tested this patch and found that it made the keysc behavior worse.
> Please stop applying the patch.
>
> I will investigate the cause of the issue and send a patch latar.
>
When this patch is resubmitted it should also have a sensible changelog,
since it's obvious that this is not just a simple mechanical change.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: mach-shmobile: pfc-sh7377: modify KEYIN settings
2010-02-19 7:52 [PATCH] ARM: mach-shmobile: pfc-sh7377: modify KEYIN settings Kuninori Morimoto
2010-02-22 7:32 ` NISHIMOTO Hiroki
2010-02-22 7:41 ` Paul Mundt
@ 2010-02-23 0:58 ` NISHIMOTO Hiroki
2 siblings, 0 replies; 4+ messages in thread
From: NISHIMOTO Hiroki @ 2010-02-23 0:58 UTC (permalink / raw)
To: linux-sh
Sorry, the issue is my test environment.
This patch remedy a keysc setting.
Please apply this patch.
Paul Mundt wrote:
> On Mon, Feb 22, 2010 at 04:32:28PM +0900, NISHIMOTO Hiroki wrote:
>
>> I tested this patch and found that it made the keysc behavior worse.
>> Please stop applying the patch.
>>
>> I will investigate the cause of the issue and send a patch latar.
>>
>>
> When this patch is resubmitted it should also have a sensible changelog,
> since it's obvious that this is not just a simple mechanical change.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-02-23 0:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-19 7:52 [PATCH] ARM: mach-shmobile: pfc-sh7377: modify KEYIN settings Kuninori Morimoto
2010-02-22 7:32 ` NISHIMOTO Hiroki
2010-02-22 7:41 ` Paul Mundt
2010-02-23 0:58 ` NISHIMOTO Hiroki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).