linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: mach-ecovec24: Add i2c_put_adapter on sh_eth_init
Date: Tue, 23 Mar 2010 04:33:03 +0000	[thread overview]
Message-ID: <20100323043303.GD13417@linux-sh.org> (raw)
In-Reply-To: <uy6htyqgy.wl%morimoto.kuninori@renesas.com>

On Tue, Mar 16, 2010 at 11:01:33AM +0900, Kuninori Morimoto wrote:
> i2c_put_adapter is needed after i2c_get_adapter
> 
> Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com>
> ---
>  arch/sh/boards/mach-ecovec24/setup.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)

On Tue, Mar 16, 2010 at 11:01:53AM +0900, Kuninori Morimoto wrote:
> Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com>
> ---
>  arch/sh/boards/mach-se/7724/setup.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)

On Tue, Mar 16, 2010 at 11:02:08AM +0900, Kuninori Morimoto wrote:
> Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com>
> ---
> In fact, ${LINUX}/arch/sh/kernel/reboot.c :: watchdog_trigger_immediate
> call sh_wdt_write_csr(0xC2);
> But SH7722/SH7723/SH7724 doesn't have 0x40 (= WTCSR_WT) bit.
> It will be just ignored, but should I add any MASK ?
> 
>  arch/sh/include/cpu-sh4/cpu/watchdog.h |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)

applied, thanks.

The watchdog stuff needs a bit of a rework, so I wouldn't worry about it
for now. It's on my TODO list.

      reply	other threads:[~2010-03-23  4:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-16  2:01 [PATCH] sh: mach-ecovec24: Add i2c_put_adapter on sh_eth_init Kuninori Morimoto
2010-03-23  4:33 ` Paul Mundt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100323043303.GD13417@linux-sh.org \
    --to=lethal@linux-sh.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).