* [PATCH] sh: mach-ecovec24: Add i2c_put_adapter on sh_eth_init
@ 2010-03-16 2:01 Kuninori Morimoto
2010-03-23 4:33 ` Paul Mundt
0 siblings, 1 reply; 2+ messages in thread
From: Kuninori Morimoto @ 2010-03-16 2:01 UTC (permalink / raw)
To: linux-sh
i2c_put_adapter is needed after i2c_get_adapter
Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com>
---
arch/sh/boards/mach-ecovec24/setup.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/sh/boards/mach-ecovec24/setup.c b/arch/sh/boards/mach-ecovec24/setup.c
index 39ed872..6c13b92 100644
--- a/arch/sh/boards/mach-ecovec24/setup.c
+++ b/arch/sh/boards/mach-ecovec24/setup.c
@@ -836,6 +836,8 @@ static void __init sh_eth_init(struct sh_eth_plat_data *pd)
pd->mac_addr[i] = mac_read(a, 0x10 + i);
msleep(10);
}
+
+ i2c_put_adapter(a);
}
#else
static void __init sh_eth_init(struct sh_eth_plat_data *pd)
--
1.6.3.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sh: mach-ecovec24: Add i2c_put_adapter on sh_eth_init
2010-03-16 2:01 [PATCH] sh: mach-ecovec24: Add i2c_put_adapter on sh_eth_init Kuninori Morimoto
@ 2010-03-23 4:33 ` Paul Mundt
0 siblings, 0 replies; 2+ messages in thread
From: Paul Mundt @ 2010-03-23 4:33 UTC (permalink / raw)
To: linux-sh
On Tue, Mar 16, 2010 at 11:01:33AM +0900, Kuninori Morimoto wrote:
> i2c_put_adapter is needed after i2c_get_adapter
>
> Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com>
> ---
> arch/sh/boards/mach-ecovec24/setup.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
On Tue, Mar 16, 2010 at 11:01:53AM +0900, Kuninori Morimoto wrote:
> Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com>
> ---
> arch/sh/boards/mach-se/7724/setup.c | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
On Tue, Mar 16, 2010 at 11:02:08AM +0900, Kuninori Morimoto wrote:
> Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com>
> ---
> In fact, ${LINUX}/arch/sh/kernel/reboot.c :: watchdog_trigger_immediate
> call sh_wdt_write_csr(0xC2);
> But SH7722/SH7723/SH7724 doesn't have 0x40 (= WTCSR_WT) bit.
> It will be just ignored, but should I add any MASK ?
>
> arch/sh/include/cpu-sh4/cpu/watchdog.h | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
applied, thanks.
The watchdog stuff needs a bit of a rework, so I wouldn't worry about it
for now. It's on my TODO list.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-23 4:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-16 2:01 [PATCH] sh: mach-ecovec24: Add i2c_put_adapter on sh_eth_init Kuninori Morimoto
2010-03-23 4:33 ` Paul Mundt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).