From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] serial: sh-sci: fix SH-Mobile SH breakage
Date: Tue, 23 Mar 2010 04:33:15 +0000 [thread overview]
Message-ID: <20100323043315.GE13417@linux-sh.org> (raw)
In-Reply-To: <20100316112107.25732.49922.sendpatchset@t400s>
On Tue, Mar 16, 2010 at 08:21:07PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
>
> The follwing commit breaks SH-Mobile on non-ARM platforms:
> "8a77b8d serial: sh-sci: Support ARM-based SH-Mobile CPUs."
>
> The commit assumed that CONFIG_ARCH_SHMOBILE only was set
> on ARM platforms, but it turns out that this kconfig is also
> set by all SH-based SoCs. Sh7724 and other older SH-Mobile
> SoCs are all broken without this fix.
>
> This patch converts the "defined(CONFIG_ARCH_SHMOBILE)" into
> one "defined()" per SoC model - similar to existing SH code.
>
> Reported-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Signed-off-by: Magnus Damm <damm@opensource.se>
Applied, thanks.
prev parent reply other threads:[~2010-03-23 4:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 11:21 [PATCH] serial: sh-sci: fix SH-Mobile SH breakage Magnus Damm
2010-03-23 4:33 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100323043315.GE13417@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).